Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: content/shell/browser/shell_browser_main_parts.h

Issue 2393853002: Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. (Closed)
Patch Set: Cleanups, pre re-review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_ 5 #ifndef CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_
6 #define CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_ 6 #define CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "content/public/browser/browser_main_parts.h" 12 #include "content/public/browser/browser_main_parts.h"
13 #include "content/public/common/main_function_params.h" 13 #include "content/public/common/main_function_params.h"
14 #include "content/shell/browser/shell_browser_context.h" 14 #include "content/shell/browser/shell_browser_context.h"
15 15
16 #if defined(OS_ANDROID) 16 #if defined(OS_ANDROID)
17 namespace breakpad { 17 namespace breakpad {
18 class CrashDumpManager; 18 class CrashDumpObserver;
19 } 19 }
20 #endif 20 #endif
21 21
22 namespace net { 22 namespace net {
23 class NetLog; 23 class NetLog;
24 } 24 }
25 25
26 namespace content { 26 namespace content {
27 27
28 class ShellBrowserMainParts : public BrowserMainParts { 28 class ShellBrowserMainParts : public BrowserMainParts {
(...skipping 25 matching lines...) Expand all
54 virtual void InitializeMessageLoopContext(); 54 virtual void InitializeMessageLoopContext();
55 55
56 void set_browser_context(ShellBrowserContext* context) { 56 void set_browser_context(ShellBrowserContext* context) {
57 browser_context_.reset(context); 57 browser_context_.reset(context);
58 } 58 }
59 void set_off_the_record_browser_context(ShellBrowserContext* context) { 59 void set_off_the_record_browser_context(ShellBrowserContext* context) {
60 off_the_record_browser_context_.reset(context); 60 off_the_record_browser_context_.reset(context);
61 } 61 }
62 62
63 private: 63 private:
64 #if defined(OS_ANDROID)
65 std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;
66 #endif
67 std::unique_ptr<net::NetLog> net_log_; 64 std::unique_ptr<net::NetLog> net_log_;
68 std::unique_ptr<ShellBrowserContext> browser_context_; 65 std::unique_ptr<ShellBrowserContext> browser_context_;
69 std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_; 66 std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_;
70 67
71 // For running content_browsertests. 68 // For running content_browsertests.
72 const MainFunctionParams parameters_; 69 const MainFunctionParams parameters_;
73 bool run_message_loop_; 70 bool run_message_loop_;
74 71
72 #if defined(OS_ANDROID)
73 std::unique_ptr<breakpad::CrashDumpObserver> crash_dump_observer_;
74 #endif
75
75 DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts); 76 DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts);
76 }; 77 };
77 78
78 } // namespace content 79 } // namespace content
79 80
80 #endif // CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_ 81 #endif // CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698