Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton.

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 48ee5e3d74962a6fe05623ca8d7f2ae0be3f8108..5b8d3b1d47fd49cc4129f9de5812aece14ddf7e4 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2778,18 +2778,8 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
   fd = ui::GetLocalePackFd(&(*regions)[kAndroidLocalePakDescriptor]);
   mappings->Share(kAndroidLocalePakDescriptor, fd);
 
-  if (breakpad::IsCrashReporterEnabled()) {
-    base::File file =
-        breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
-            child_process_id);
-    if (file.IsValid()) {
-      mappings->Transfer(kAndroidMinidumpDescriptor,
-                         base::ScopedFD(file.TakePlatformFile()));
-    } else {
-      LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
-                 "be disabled for this process.";
-    }
-  }
+  breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(

[boliu, 2016/10/13 21:07:18]

so now we transfer the handles regardless of whether breakpad is enabled?
intentional change?

[boliu, 2016/10/13 21:08:50]

Oops, read that one wrong, ignore..

[Tobias Sargeant, 2016/12/08 16:41:41]

Acknowledged.

+      child_process_id, mappings);
 
   base::FilePath app_data_path;
   PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);