Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <map>
 #include <set>
 #include <utility>
 #include <vector>
@@ skipping 2760 matching lines @@
       &(*regions)[kAndroidUIResourcesPakDescriptor]);
   mappings->Share(kAndroidUIResourcesPakDescriptor, fd);
 
   fd = ui::GetCommonResourcesPackFd(
       &(*regions)[kAndroidChrome100PercentPakDescriptor]);
   mappings->Share(kAndroidChrome100PercentPakDescriptor, fd);
 
   fd = ui::GetLocalePackFd(&(*regions)[kAndroidLocalePakDescriptor]);
   mappings->Share(kAndroidLocalePakDescriptor, fd);
 
-  if (breakpad::IsCrashReporterEnabled()) {
-    base::File file =
-        breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
-            child_process_id);
-    if (file.IsValid()) {
-      mappings->Transfer(kAndroidMinidumpDescriptor,
-                         base::ScopedFD(file.TakePlatformFile()));
-    } else {
-      LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
-                 "be disabled for this process.";
-    }
-  }
+  breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(

[boliu, 2016/10/13 21:07:18]

so now we transfer the handles regardless of whether breakpad is enabled?
intentional change?

[boliu, 2016/10/13 21:08:50]

Oops, read that one wrong, ignore..

[Tobias Sargeant, 2016/12/08 16:41:41]

Acknowledged.

+      child_process_id, mappings);
 
   base::FilePath app_data_path;
   PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);
   DCHECK(!app_data_path.empty());
 }
 #elif defined(OS_POSIX) && !defined(OS_MACOSX)
 void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
     const base::CommandLine& command_line,
     int child_process_id,
     FileDescriptorInfo* mappings) {
@@ skipping 474 matching lines @@
   if (channel <= kMaxDisableEncryptionChannel) {
     static const char* const kWebRtcDevSwitchNames[] = {
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)