Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2393803004: blink: Enforce comment formatting (except in core/layout, for now) (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, szager+layoutwatch_chromium.org, eae+blinkwatch, apavlov+blink_chromium.org, kinuko+watch, blink-reviews-wtf_chromium.org, rwlbuis, caseq+blink_chromium.org, blink-reviews-html_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, blink-reviews, zoltan1, blink-reviews-layout_chromium.org, sof, lushnikov+blink_chromium.org, haraken, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, pfeldman+blink_chromium.org, Mikhail, kozyatinskiy+blink_chromium.org, dominicc (has gone to gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Enforce comment formatting. All of blink's comments are now reflown [1], so we can stop telling clang-format that it shouldn't touch comments. Delete third_party/WebKit/.clang-format, since the top-level .clang-format file now works for blink. Also reflow a few straggler comments that made it in in the last day. 1: core/layout isn't completely done yet, so suppress comment reflow enforcement in core/layout until the last two patches there made it through the cq. BUG=563793 NOTRY=true Committed: https://crrev.com/d3e0e6655a412956248d217baa397c5f6af2bbd3 Cr-Commit-Position: refs/heads/master@{#423558}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -51 lines) Patch
D third_party/WebKit/.clang-format View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/bindings/.clang-format View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/CoreInitializer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 2 chunks +3 lines, -7 lines 1 comment Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/layout/.clang-format View 1 chunk +5 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/modules/.clang-format View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/platform/.clang-format View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/web/.clang-format View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/wtf/.clang-format View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Nico
https://codereview.chromium.org/2393803004/diff/1/third_party/WebKit/Source/core/dom/Text.cpp File third_party/WebKit/Source/core/dom/Text.cpp (left): https://codereview.chromium.org/2393803004/diff/1/third_party/WebKit/Source/core/dom/Text.cpp#oldcode311 third_party/WebKit/Source/core/dom/Text.cpp:311: unsigned maxSiblingsToVisit = 50; It looks like https://codereview.chromium.org/2379483002/diff/60001/third_party/WebKit/Source/core/dom/Text.cpp#newcode311 forgot ...
4 years, 2 months ago (2016-10-06 15:21:04 UTC) #4
dcheng
LGTM
4 years, 2 months ago (2016-10-06 15:22:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393803004/1
4 years, 2 months ago (2016-10-06 15:30:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393803004/1
4 years, 2 months ago (2016-10-06 16:26:19 UTC) #14
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/.clang-format: While running git rm third_party/WebKit/.clang-format; fatal: pathspec 'third_party/WebKit/.clang-format' did ...
4 years, 2 months ago (2016-10-06 16:32:50 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 16:33:07 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3e0e6655a412956248d217baa397c5f6af2bbd3
Cr-Commit-Position: refs/heads/master@{#423558}

Powered by Google App Engine
This is Rietveld 408576698