Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Issue 2393793003: [Merge-M54] arc: Fix Arc app item context menu. (Closed)

Created:
4 years, 2 months ago by khmel
Modified:
4 years, 2 months ago
Reviewers:
reviewer
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, Matt Giuca, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge-M54] arc: Fix Arc app item context menu. This fixes arc context menu. Original bug requests to make "Show app info" menu item disable when Arc is not ready only. This also includes following related fixes: 1. "Show app info" is disabled until Arc is started. 2. Before "Uninstall" was not shown when Arc is not started. This also makes it disable in this case for consistency. 3. Add separator before "Uninstall/Show app info" group regardless "Uninstall" item is shown or not. Before, "Show app info" menu was not separated in case uninstall was not present. 4. "Uninstall" shortcut is available always, regardless of Arc enabled or disabled. 5. No menu items for non-existing Arc app. TEST=Manually on the device. TEST=Extended unit_tests. BUG=652741 BUG=b/30646620 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2393453002 Cr-Commit-Position: refs/heads/master@{#422831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -97 lines) Patch
M chrome/browser/ui/app_list/app_context_menu_unittest.cc View 6 chunks +98 lines, -76 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_context_menu.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_context_menu.cc View 3 chunks +36 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393793003/1
4 years, 2 months ago (2016-10-06 01:23:10 UTC) #2
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:25:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698