arc: Fix Arc app item context menu.

arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=652741
BUG=b/30646620

Committed: https://crrev.com/cafda50c9b7ebdfd57b680b1027050e414f2681f
Cr-Commit-Position: refs/heads/master@{#422831}

[khmel, 2016-10-03 23:46:38]

Description was changed from

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=
==========

to

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=
==========

[khmel, 2016-10-03 23:48:02]

khmel@chromium.org changed reviewers:
+ xiyuan@chromium.org

[khmel, 2016-10-03 23:48:03]

Hi Xiyuan,

PTAL

https://codereview.chromium.org/2393453002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/app_context_menu_unittest.cc (right):

https://codereview.chromium.org/2393453002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/app_context_menu_unittest.cc:357: const
arc::mojom::AppInfo& app_info = arc_test.fake_apps()[1];
0 app is sticky and does not have uninstall item. We have one more test case for
this bellow. It is beneficial to test normal case here.

https://codereview.chromium.org/2393453002/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/arc/arc_app_context_menu.h (left):

https://codereview.chromium.org/2393453002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_context_menu.h:39: bool
CanBeUninstalled() const;
Moved code to the place when it is used.

https://codereview.chromium.org/2393453002/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/arc/arc_app_context_menu.h:40: bool IsShortcut()
const;
Never used

[xiyuan, 2016-10-04 16:31:48]

lgtm

[khmel, 2016-10-04 16:35:26]

Description was changed from

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=
==========

to

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=652741
BUG=b/30646620
==========

[khmel, 2016-10-04 16:35:39]

Thank you for quick review!

[khmel, 2016-10-04 16:35:43]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2016-10-04 16:36:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 17:01:18]

Description was changed from

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=652741
BUG=b/30646620
==========

to

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=652741
BUG=b/30646620
==========

[commit-bot: I haz the power, 2016-10-04 17:01:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 17:03:37]

Description was changed from

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=652741
BUG=b/30646620
==========

to

==========
arc: Fix Arc app item context menu.

This fixes arc context menu. Original bug requests to make
"Show app info" menu item disable when Arc is not ready only.
This also includes following related fixes:
  1. "Show app info" is disabled until Arc is started.
  2. Before "Uninstall" was not shown when Arc is not started.
     This also makes it disable in this case for consistency.
  3. Add separator before "Uninstall/Show app info" group regardless
     "Uninstall" item is shown or not. Before, "Show app info" menu
     was not separated in case uninstall was not present.
  4. "Uninstall" shortcut is available always, regardless of
     Arc enabled or disabled.
  5. No menu items for non-existing Arc app.
TEST=Manually on the device.
TEST=Extended unit_tests.
BUG=652741
BUG=b/30646620

Committed: https://crrev.com/cafda50c9b7ebdfd57b680b1027050e414f2681f
Cr-Commit-Position: refs/heads/master@{#422831}
==========

[commit-bot: I haz the power, 2016-10-04 17:03:38]

Patchset 1 (id:??) landed as
https://crrev.com/cafda50c9b7ebdfd57b680b1027050e414f2681f
Cr-Commit-Position: refs/heads/master@{#422831}