Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1501)

Unified Diff: test/unittests/interpreter/bytecode-pipeline-unittest.cc

Issue 2393683004: [Interpreter] Optimize the Register Optimizer. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/interpreter/bytecode-pipeline-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-pipeline-unittest.cc b/test/unittests/interpreter/bytecode-pipeline-unittest.cc
index 4399dce6f96afad92b44faece3a813682525cbe0..5591d767bf7d7aa4577fda75a29d56726f3ce3a6 100644
--- a/test/unittests/interpreter/bytecode-pipeline-unittest.cc
+++ b/test/unittests/interpreter/bytecode-pipeline-unittest.cc
@@ -115,11 +115,11 @@ TEST_F(BytecodeNodeTest, EqualityWithSourceInfo) {
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
BytecodeSourceInfo first_source_info(3, true);
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
- operands[3], &first_source_info);
+ operands[3], first_source_info);
CHECK_EQ(node, node);
BytecodeSourceInfo second_source_info(3, true);
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
- operands[2], operands[3], &second_source_info);
+ operands[2], operands[3], second_source_info);
CHECK_EQ(node, other);
}
@@ -127,49 +127,40 @@ TEST_F(BytecodeNodeTest, NoEqualityWithDifferentSourceInfo) {
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
BytecodeSourceInfo source_info(77, true);
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
- operands[3], &source_info);
+ operands[3], source_info);
BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
operands[2], operands[3]);
CHECK_NE(node, other);
}
-TEST_F(BytecodeNodeTest, Clone) {
- uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
- BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
- operands[3]);
- BytecodeNode clone(Bytecode::kIllegal);
- clone.Clone(&node);
- CHECK_EQ(clone, node);
-}
-
TEST_F(BytecodeNodeTest, SetBytecode0) {
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
BytecodeSourceInfo source_info(77, false);
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
- operands[3], &source_info);
- CHECK_EQ(node.source_info(), BytecodeSourceInfo(77, false));
+ operands[3], source_info);
+ CHECK_EQ(node.source_info(), source_info);
BytecodeNode clone(Bytecode::kIllegal);
- clone.Clone(&node);
+ clone = node;
clone.set_bytecode(Bytecode::kNop);
CHECK_EQ(clone.bytecode(), Bytecode::kNop);
CHECK_EQ(clone.operand_count(), 0);
- CHECK_EQ(clone.source_info(), BytecodeSourceInfo(77, false));
+ CHECK_EQ(clone.source_info(), source_info);
}
TEST_F(BytecodeNodeTest, SetBytecode1) {
uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
BytecodeSourceInfo source_info(77, false);
BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
- operands[3], &source_info);
+ operands[3], source_info);
BytecodeNode clone(Bytecode::kIllegal);
- clone.Clone(&node);
+ clone = node;
clone.set_bytecode(Bytecode::kJump, 0x01aabbcc);
CHECK_EQ(clone.bytecode(), Bytecode::kJump);
CHECK_EQ(clone.operand_count(), 1);
CHECK_EQ(clone.operand(0), 0x01aabbcc);
- CHECK_EQ(clone.source_info(), BytecodeSourceInfo(77, false));
+ CHECK_EQ(clone.source_info(), source_info);
}
} // namespace interpreter

Powered by Google App Engine
This is Rietveld 408576698