[Interpreter] Optimize the Register Optimizer.

test/unittests/interpreter/bytecode-pipeline-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/interpreter/bytecode-pipeline.h"
 #include "src/interpreter/bytecode-register-allocator.h"
 #include "src/isolate.h"
 #include "test/unittests/test-utils.h"
@@ skipping 97 matching lines @@
   CHECK_EQ(node, node);
   BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
                      operands[2], operands[3]);
   CHECK_EQ(node, other);
 }
 
 TEST_F(BytecodeNodeTest, EqualityWithSourceInfo) {
   uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
   BytecodeSourceInfo first_source_info(3, true);
   BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
-                    operands[3], &first_source_info);
+                    operands[3], first_source_info);
   CHECK_EQ(node, node);
   BytecodeSourceInfo second_source_info(3, true);
   BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
-                     operands[2], operands[3], &second_source_info);
+                     operands[2], operands[3], second_source_info);
   CHECK_EQ(node, other);
 }
 
 TEST_F(BytecodeNodeTest, NoEqualityWithDifferentSourceInfo) {
   uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
   BytecodeSourceInfo source_info(77, true);
   BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
-                    operands[3], &source_info);
+                    operands[3], source_info);
   BytecodeNode other(Bytecode::kForInNext, operands[0], operands[1],
                      operands[2], operands[3]);
   CHECK_NE(node, other);
 }
 
-TEST_F(BytecodeNodeTest, Clone) {
-  uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
-  BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
-                    operands[3]);
-  BytecodeNode clone(Bytecode::kIllegal);
-  clone.Clone(&node);
-  CHECK_EQ(clone, node);
-}
-
 TEST_F(BytecodeNodeTest, SetBytecode0) {
   uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
   BytecodeSourceInfo source_info(77, false);
   BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
-                    operands[3], &source_info);
-  CHECK_EQ(node.source_info(), BytecodeSourceInfo(77, false));
+                    operands[3], source_info);
+  CHECK_EQ(node.source_info(), source_info);
 
   BytecodeNode clone(Bytecode::kIllegal);
-  clone.Clone(&node);
+  clone = node;
   clone.set_bytecode(Bytecode::kNop);
   CHECK_EQ(clone.bytecode(), Bytecode::kNop);
   CHECK_EQ(clone.operand_count(), 0);
-  CHECK_EQ(clone.source_info(), BytecodeSourceInfo(77, false));
+  CHECK_EQ(clone.source_info(), source_info);
 }
 
 TEST_F(BytecodeNodeTest, SetBytecode1) {
   uint32_t operands[] = {0x71, 0xa5, 0x5a, 0xfc};
   BytecodeSourceInfo source_info(77, false);
   BytecodeNode node(Bytecode::kForInNext, operands[0], operands[1], operands[2],
-                    operands[3], &source_info);
+                    operands[3], source_info);
 
   BytecodeNode clone(Bytecode::kIllegal);
-  clone.Clone(&node);
+  clone = node;
   clone.set_bytecode(Bytecode::kJump, 0x01aabbcc);
   CHECK_EQ(clone.bytecode(), Bytecode::kJump);
   CHECK_EQ(clone.operand_count(), 1);
   CHECK_EQ(clone.operand(0), 0x01aabbcc);
-  CHECK_EQ(clone.source_info(), BytecodeSourceInfo(77, false));
+  CHECK_EQ(clone.source_info(), source_info);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8