Issue 23936007: To diagnose chromium bug 284577, some additional CHECKS. TODOs are

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23936007: To diagnose chromium bug 284577, some additional CHECKS. TODOs are (Closed)

Created:
7 years, 3 months ago by mvstanton

Modified:
7 years, 2 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

To diagnose chromium bug 284577, some additional CHECKS. TODOs are added so these can be backed out once the cause of the bug is determined. BUG= R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16654

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed nit #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -10 lines)			Patch
M	src/hydrogen.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	src/objects-debug.cc	View		2 chunks	+24 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

LGTM, one nit. https://codereview.chromium.org/23936007/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/23936007/diff/1/src/hydrogen.cc#newcode1841 src/hydrogen.cc:1841: // HObjectAccess::ForAllocationSiteTransitionInfo()); I guess you are ...

7 years, 3 months ago (2013-09-11 13:25:34 UTC) #2

mvstanton

7 years, 3 months ago (2013-09-11 13:39:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16654 (presubmit successful).

Expand Messages | Collapse Messages