src/hydrogen.cc - Issue 23936007: To diagnose chromium bug 284577, some additional CHECKS. TODOs are

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 23936007: To diagnose chromium bug 284577, some additional CHECKS. TODOs are (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed nit Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 437d29b82e75a900410352d1e5261c4f6b7791be..f2cdf3a6d3be946ee8c09284db945be6385e7b5b 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -1824,7 +1824,8 @@ void HGraphBuilder::BuildCompareNil(

HValue* HGraphBuilder::BuildCreateAllocationMemento(HValue* previous_object,

int previous_object_size,

HValue* alloc_site) {

- ASSERT(alloc_site != NULL);

+ // TODO(mvstanton): ASSERT altered to CHECK to diagnose chromium bug 284577

+ CHECK(alloc_site != NULL);

HInnerAllocatedObject* alloc_memento = Add<HInnerAllocatedObject>(

previous_object, previous_object_size);

Handle<Map> alloc_memento_map(

« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »