Delay installing supplement objects

Delay installing supplement objects

Currently supplement objects are installed before window->document() is set.
This is problematic (accurately, this will become a problem when I remove DOMWindowProperty
in a follow-up patch) because the supplement objects cannot be associated with
ContextLifecycleObserver when they are instantiated.
We should install supplement objects after window->document() is set.

BUG=610176
Committed: https://crrev.com/52548aab6ce67bf935040946021baba7f57e2a53
Cr-Commit-Position: refs/heads/master@{#423126}

[haraken, 2016-10-04 12:22:30]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org

[haraken, 2016-10-04 12:22:30]

PTAL

[haraken, 2016-10-04 12:22:37]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 12:22:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 13:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:06:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2016-10-04 14:54:13]

(I need to fix the test failures...)

[haraken, 2016-10-05 04:57:31]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 04:57:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 05:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 05:06:08]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-10-05 05:07:57]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 05:08:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-10-05 06:48:32]

Now the test passes. PTAL.

[commit-bot: I haz the power, 2016-10-05 07:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 07:04:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-10-05 07:23:31]

LGTM, this change makes sense to me: if we need to install a new document, then
we install new supplements.

[haraken, 2016-10-05 08:53:15]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-10-05 08:53:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 10:42:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-05 10:44:11]

Description was changed from

==========
Delay installing supplement objects

Currently supplement objects are installed before window->document() is set.
This is problematic (accurately, this will become a problem when I remove
DOMWindowProperty
in a follow-up patch) because the supplement objects cannot be associated with
ContextLifecycleObserver when they are instantiated.
We should install supplement objects after window->document() is set.

BUG=610176
==========

to

==========
Delay installing supplement objects

Currently supplement objects are installed before window->document() is set.
This is problematic (accurately, this will become a problem when I remove
DOMWindowProperty
in a follow-up patch) because the supplement objects cannot be associated with
ContextLifecycleObserver when they are instantiated.
We should install supplement objects after window->document() is set.

BUG=610176

Committed: https://crrev.com/52548aab6ce67bf935040946021baba7f57e2a53
Cr-Commit-Position: refs/heads/master@{#423126}
==========

[commit-bot: I haz the power, 2016-10-05 10:44:12]

Patchset 4 (id:??) landed as
https://crrev.com/52548aab6ce67bf935040946021baba7f57e2a53
Cr-Commit-Position: refs/heads/master@{#423126}