Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2393523002: Delay installing supplement objects (Closed)
Patch Set: temp Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index abd6e8f63e13730ed35330d38dd3ae56f6ea984b..af497496f4ada58c55f4da914f4dd25868fba4f0 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -476,6 +476,7 @@ void LocalFrame::detachChildren() {
}
void LocalFrame::setDOMWindow(LocalDOMWindow* domWindow) {
+ // TODO(haraken): Update this comment.
// Oilpan: setDOMWindow() cannot be used when finalizing. Which
// is acceptable as its actions are either not needed or handled
// by other means --
@@ -496,7 +497,6 @@ void LocalFrame::setDOMWindow(LocalDOMWindow* domWindow) {
if (m_domWindow)
m_domWindow->reset();
m_domWindow = domWindow;
- page()->chromeClient().installSupplements(*this);
}
Document* LocalFrame::document() const {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698