third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.cpp - Issue 2393513004: Convert app banners to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.cpp

Issue 2393513004: Convert app banners to use Mojo. (Closed)

Patch Set: Fix Win clang compile Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp ('K') | « third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h ('k') | third_party/WebKit/Source/modules/app_banner/BUILD.gn » ('j') | third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.cpp

diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.cpp b/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.cpp

index 3ed9b45567f784a5d6d47781bf418149a2429071..e0c0bdebc526c222c21364cc8a174d67128791e5 100644

--- a/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.cpp

+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.cpp

@@ -24,7 +24,7 @@ String AppBannerPromptResult::outcome() const {

}

AppBannerPromptResult::AppBannerPromptResult(

- const AtomicString& platform,

+ const String& platform,

WebAppBannerPromptResult::Outcome outcome)

: m_platform(platform), m_outcome(outcome) {}