Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h

Issue 2393513004: Convert app banners to use Mojo. (Closed)
Patch Set: Fix Win clang compile Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
diff --git a/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h b/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
index dc38d0a89acf6f1c94c20c1c1ab71ca1ae2d0ef0..021164b49935c7d81e56939e3ef06e022b5d8755 100644
--- a/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
+++ b/third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h
@@ -12,8 +12,6 @@
namespace blink {
-class ScriptPromiseResolver;
-
class AppBannerPromptResult final
: public GarbageCollectedFinalized<AppBannerPromptResult>,
public ScriptWrappable {
@@ -22,7 +20,7 @@ class AppBannerPromptResult final
public:
static AppBannerPromptResult* create(
- const AtomicString& platform,
+ const String& platform,
WebAppBannerPromptResult::Outcome outcome) {
return new AppBannerPromptResult(platform, outcome);
}
@@ -35,7 +33,7 @@ class AppBannerPromptResult final
DEFINE_INLINE_VIRTUAL_TRACE() {}
private:
- AppBannerPromptResult(const AtomicString& platform,
+ AppBannerPromptResult(const String& platform,
WebAppBannerPromptResult::Outcome);
String m_platform;

Powered by Google App Engine
This is Rietveld 408576698