chrome/browser/android/banners/app_banner_manager_android.cc - Issue 2393513004: Convert app banners to use Mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2393513004: Convert app banners to use Mojo. (Closed)

Patch Set: Remove WebAppBannerPromptResult Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/banners/app_banner_manager_android.cc

diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc

index d298606e8ce831cff2cf49c53d6b1efddc96d0e8..2945ec21e943f9a54170080f48374b17139d66dd 100644

--- a/chrome/browser/android/banners/app_banner_manager_android.cc

+++ b/chrome/browser/android/banners/app_banner_manager_android.cc

@@ -2,10 +2,11 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include <utility>

#include "chrome/browser/android/banners/app_banner_manager_android.h"

+#include <memory>

+#include <utility>

#include "base/android/jni_android.h"

#include "base/android/jni_string.h"

#include "base/memory/ptr_util.h"

@@ -18,7 +19,6 @@

#include "chrome/browser/banners/app_banner_metrics.h"

#include "chrome/browser/manifest/manifest_icon_downloader.h"

#include "chrome/browser/manifest/manifest_icon_selector.h"

-#include "chrome/common/chrome_constants.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/frame_navigate_params.h"

#include "jni/AppBannerManager_jni.h"

@@ -128,7 +128,7 @@ std::string AppBannerManagerAndroid::GetAppIdentifier() {

std::string AppBannerManagerAndroid::GetBannerType() {

return native_app_data_.is_null() ? AppBannerManager::GetBannerType()

- : "android";

+ : "play";

pkotwicz1 2016/10/06 15:45:28 Drive by: It is probably worth calling out this ch

dominickn 2016/10/06 22:58:12 This fixes an inconsistency where the AppBannerInf

}

int AppBannerManagerAndroid::GetIdealIconSizeInDp() {