Convert app banners to use Mojo.

chrome/browser/android/banners/app_banner_manager_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/browser/android/banners/app_banner_manager_android.h"
+
+#include <memory>
 #include <utility>
 
-#include "chrome/browser/android/banners/app_banner_manager_android.h"
-
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 #include "chrome/browser/android/shortcut_helper.h"
 #include "chrome/browser/android/webapk/chrome_webapk_host.h"
 #include "chrome/browser/android/webapk/webapk_metrics.h"
 #include "chrome/browser/android/webapk/webapk_web_manifest_checker.h"
 #include "chrome/browser/banners/app_banner_metrics.h"
 #include "chrome/browser/manifest/manifest_icon_downloader.h"
 #include "chrome/browser/manifest/manifest_icon_selector.h"
-#include "chrome/common/chrome_constants.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/frame_navigate_params.h"
 #include "jni/AppBannerManager_jni.h"
 #include "net/base/url_util.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertJavaStringToUTF16;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::JavaParamRef;
@@ skipping 89 matching lines @@
   AppBannerManager::RequestAppBanner(validated_url, is_debug_mode);
 }
 
 std::string AppBannerManagerAndroid::GetAppIdentifier() {
   return native_app_data_.is_null() ? AppBannerManager::GetAppIdentifier()
                                     : native_app_package_;
 }
 
 std::string AppBannerManagerAndroid::GetBannerType() {
   return native_app_data_.is_null() ? AppBannerManager::GetBannerType()
-                                    : "android";
+                                    : "play";

[pkotwicz1, 2016/10/06 15:45:28]

Drive by: It is probably worth calling out this change in the CL description

[dominickn, 2016/10/06 22:58:12]

This fixes an inconsistency where the AppBannerInfoBarDelegate sent "play" when
BeforeInstallPrompt resolved and the Manager sent "android" to init the event. I
didn't call out this cleanup because the string sent when the event resolves is
explicitly tested and the init string is basically never touched (and it's never
specified what exactly it will be).

 }
 
 int AppBannerManagerAndroid::GetIdealIconSizeInDp() {
   return ShortcutHelper::GetIdealHomescreenIconSizeInDp();
 }
 
 int AppBannerManagerAndroid::GetMinimumIconSizeInDp() {
   return ShortcutHelper::GetMinimumHomescreenIconSizeInDp();
 }
 
@@ skipping 173 matching lines @@
 }
 
 // static
 void SetTimeDeltaForTesting(JNIEnv* env,
                             const JavaParamRef<jclass>& clazz,
                             jint days) {
   AppBannerManager::SetTimeDeltaForTesting(days);
 }
 
 }  // namespace banners