Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2393453003: [interpreter] Add some bytecode tests for modules. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add some bytecode tests for modules. R=rmcilroy@chromium.org BUG= Committed: https://crrev.com/1744727d82b2ecf6b221cb7fc70195a9dbcd2cbe Cr-Commit-Position: refs/heads/master@{#39963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+988 lines, -9 lines) Patch
M test/cctest/interpreter/bytecode-expectations-printer.h View 4 chunks +9 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode-expectations-printer.cc View 3 chunks +25 lines, -7 lines 0 comments Download
A test/cctest/interpreter/bytecode_expectations/Modules.golden View 1 chunk +896 lines, -0 lines 0 comments Download
M test/cctest/interpreter/generate-bytecode-expectations.cc View 9 chunks +17 lines, -1 line 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
neis
4 years, 2 months ago (2016-10-04 16:10:50 UTC) #1
rmcilroy
Looks great, thanks! LGTM.
4 years, 2 months ago (2016-10-04 16:22:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393453003/1
4 years, 2 months ago (2016-10-04 18:16:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 18:42:19 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:42:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1744727d82b2ecf6b221cb7fc70195a9dbcd2cbe
Cr-Commit-Position: refs/heads/master@{#39963}

Powered by Google App Engine
This is Rietveld 408576698