Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2390163003: [interpreter] Remove redundant flag from bytecode cctest suite. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Remove redundant flag from bytecode cctest suite. This removes the execute_ flag, which was always the negation of top_level_. R=rmcilroy@chromium.org BUG= Committed: https://crrev.com/99cfa5f62098091267cdaf83d4e3ebad78b29d17 Cr-Commit-Position: refs/heads/master@{#39961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -97 lines) Patch
M test/cctest/interpreter/bytecode-expectations-printer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode-expectations-printer.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ArrayLiteralsWide.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BasicLoops.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallGlobal.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallLookupSlot.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallNew.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Conditional.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariable.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextParameters.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ContextVariables.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CountOperators.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CreateArguments.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CreateRestParameter.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeadCodeRemoval.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeclareGlobals.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Delete.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DeleteLookupSlotInEval.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DoDebugger.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/DoExpression.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Eval.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/FunctionLiterals.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalCompoundExpressions.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalCountOperators.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GlobalDelete.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/HeapNumberConstants.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/IfConditions.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/IntegerConstants.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/JumpsRequiringConstantWideOperands.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariable.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LetVariableContextSlot.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LoadGlobal.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LogicalExpressions.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlot.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlotInEval.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/LookupSlotWideInEval.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/NewTarget.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiterals.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ObjectLiteralsWide.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/OuterContextVariables.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Parameters.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PrimitiveExpressions.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PrimitiveReturnStatements.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyCall.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyStores.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RegExpLiterals.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RegExpLiteralsWide.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RemoveRedundantLdar.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/StoreGlobal.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/StringConstants.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Switch.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ThisFunction.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Throw.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TopLevelObjectLiterals.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryCatch.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/TryFinally.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Typeof.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/UnaryOperators.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WideRegisters.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WithStatement.golden View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/interpreter/generate-bytecode-expectations.cc View 9 chunks +4 lines, -14 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2393453003 Patch 1

Messages

Total messages: 7 (2 generated)
neis
4 years, 2 months ago (2016-10-04 15:10:14 UTC) #1
rmcilroy
LGTM, thanks!
4 years, 2 months ago (2016-10-04 16:04:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390163003/1
4 years, 2 months ago (2016-10-04 16:05:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 16:30:05 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:30:24 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/99cfa5f62098091267cdaf83d4e3ebad78b29d17
Cr-Commit-Position: refs/heads/master@{#39961}

Powered by Google App Engine
This is Rietveld 408576698