Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: blimp/engine/feature/engine_render_widget_feature.cc

Issue 2393443004: Blimp: Added spinner to text input dialog (Closed)
Patch Set: dotted line background Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/engine_render_widget_feature.cc
diff --git a/blimp/engine/feature/engine_render_widget_feature.cc b/blimp/engine/feature/engine_render_widget_feature.cc
index fccb811d2a62988b8a5bed826622bdf92535fb34..0728b132493c33827992e22d839ef39423969a3e 100644
--- a/blimp/engine/feature/engine_render_widget_feature.cc
+++ b/blimp/engine/feature/engine_render_widget_feature.cc
@@ -231,6 +231,15 @@ void EngineRenderWidgetFeature::ProcessMessage(
if (render_widget_host && render_widget_host->GetView()) {
SetTextFromIME(render_widget_host->GetView()->GetTextInputClient(),
message->ime().ime_text());
+
+ // TODO(shaktisahu): Remove this fake HIDE_IME request once the blimp
+ // IME design is completed.
+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
David Trainor- moved to gerrit 2016/10/19 16:40:31 Actually I think it's cleaner if we send this dela
shaktisahu 2016/10/27 02:42:56 Actually, today, engine is not sending a HIDE_IME
David Trainor- moved to gerrit 2016/10/28 05:08:08 Yeah I was assuming we'd just send the hide right
shaktisahu 2016/11/01 21:35:33 Done.
+ FROM_HERE,
+ base::Bind(&EngineRenderWidgetFeature::SendHideImeRequest,
+ base::Unretained(this), target_tab_id,
+ render_widget_host),
+ base::TimeDelta::FromMilliseconds(1500));
}
break;
default:

Powered by Google App Engine
This is Rietveld 408576698