Blimp: Added spinner to text input dialog

blimp/engine/feature/engine_render_widget_feature.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "blimp/engine/feature/engine_render_widget_feature.h"
 
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "blimp/common/create_blimp_message.h"
 #include "blimp/common/proto/blimp_message.pb.h"
@@ skipping 213 matching lines @@
         delegate->OnCompositorMessageReceived(render_widget_host, payload);
       }
       break;
     case BlimpMessage::kIme:
       DCHECK(message->ime().type() == ImeMessage::SET_TEXT);
       render_widget_host =
           GetRenderWidgetHost(target_tab_id, message->ime().render_widget_id());
       if (render_widget_host && render_widget_host->GetView()) {
         SetTextFromIME(render_widget_host->GetView()->GetTextInputClient(),
                        message->ime().ime_text());
+
+        // TODO(shaktisahu): Remove this fake HIDE_IME request once the blimp
+        // IME design is completed.
+        base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

[David Trainor- moved to gerrit, 2016/10/19 16:40:31]

Actually I think it's cleaner if we send this delayed from the client.  Can we
delay how we hit the callback by 0.5 seconds or something?  That already has a
callback_.Run(), now it'll be PostDelayedTask(callback_, blah blah,
base::TimeDelta::FromMilliseconds(500))?

[shaktisahu, 2016/10/27 02:42:56]

Actually, today, engine is not sending a HIDE_IME request which will cause the
spinner to spin indefinitely.

[David Trainor- moved to gerrit, 2016/10/28 05:08:08]

Yeah I was assuming we'd just send the hide right away, but it's a good point
that we can just add the delay here since we already have to call the hide
method.

Can you file a bug and tag it here?

[shaktisahu, 2016/11/01 21:35:33]

Done.

+            FROM_HERE,
+            base::Bind(&EngineRenderWidgetFeature::SendHideImeRequest,
+                       base::Unretained(this), target_tab_id,
+                       render_widget_host),
+            base::TimeDelta::FromMilliseconds(1500));
       }
       break;
     default:
       NOTREACHED();
   }
 
   callback.Run(net::OK);
 }
 
 void EngineRenderWidgetFeature::OnWebPreferencesChanged() {
@@ skipping 117 matching lines @@
   IdToRenderWidgetMap::const_iterator widget_id_it =
       id_to_render_widget->find(render_widget_id);
   if (widget_id_it == id_to_render_widget->end())
     return nullptr;
 
   return widget_id_it->second;
 }
 
 }  // namespace engine
 }  // namespace blimp