Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3563)

Unified Diff: blimp/client/app/android/java/res/layout/text_input_popup.xml

Issue 2393443004: Blimp: Added spinner to text input dialog (Closed)
Patch Set: dotted line background Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/android/java/res/layout/text_input_popup.xml
diff --git a/blimp/client/app/android/java/res/layout/text_input_popup.xml b/blimp/client/app/android/java/res/layout/text_input_popup.xml
index 456b2c10edc7b4a7ebc87e779ae92a21c76d5212..5d69b034c6538c6b18bfdf085484f34606d6e8b4 100644
--- a/blimp/client/app/android/java/res/layout/text_input_popup.xml
+++ b/blimp/client/app/android/java/res/layout/text_input_popup.xml
@@ -3,16 +3,35 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
-<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:gravity="start">
+ android:layout_height="wrap_content">
+ <TextView
David Trainor- moved to gerrit 2016/10/19 16:40:30 Are we adding the label here as well? Or is this
shaktisahu 2016/10/27 02:42:56 Yea, this is the same label used above the edit te
+ android:id="@+id/label"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="17dp"
+ android:layout_marginStart="24dp"
+ android:textSize="12sp"/>
David Trainor- moved to gerrit 2016/10/19 16:40:30 Should we be setting color/font/etc?
shaktisahu 2016/10/27 02:42:56 I think we should clean these up to use a few defi
David Trainor- moved to gerrit 2016/10/28 05:08:08 Sounds good!
<org.chromium.blimp.core.contents.input.ImeEditText
android:id="@+id/ime_edit_text"
android:inputType="text"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:textSize="18sp"
- android:singleLine="true"
- android:layout_marginTop="10dp"/>
-</FrameLayout>
+ android:layout_below="@+id/label"
+ android:layout_marginTop= "4dp"
+ android:layout_marginStart="24dp"
+ android:layout_marginEnd="24dp"
+ android:textSize="16sp"
+ android:singleLine="true"/>
+ <ProgressBar
David Trainor- moved to gerrit 2016/10/19 16:40:30 Are we relying on the OK/CANCEL buttons from the a
shaktisahu 2016/10/27 02:42:56 Done. Changed to a generic dialog and moved them t
David Trainor- moved to gerrit 2016/10/28 05:08:08 I like the name :).
+ android:id="@+id/submit_spinner"
+ style="?android:attr/progressBarStyle"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_below="@+id/ime_edit_text"
+ android:layout_centerHorizontal="true"
+ android:layout_marginTop="24dp"
+ android:indeterminate="true"
+ android:visibility="gone" />
+</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698