blimp/client/app/android/java/res/layout/text_input_popup.xml - Issue 2393443004: Blimp: Added spinner to text input dialog

Side by Side Diff: blimp/client/app/android/java/res/layout/text_input_popup.xml

Issue 2393443004: Blimp: Added spinner to text input dialog (Closed)

Patch Set: dotted line background Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« blimp/client/app/android/java/res/drawable/dotted_line.xml ('K') | « blimp/client/app/android/java/res/drawable/dotted_line.xml ('k') | blimp/client/app/android/java/res/values/colors.xml » ('j') | blimp/client/app/android/java/res/values/colors.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"	6 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

7 android:layout_width="wrap_content"	7 android:layout_width="wrap_content"

8 android:layout_height="wrap_content"	8 android:layout_height="wrap_content">

9 android:gravity="start">	9 <TextView
	David Trainor- moved to gerrit 2016/10/19 16:40:30 Are we adding the label here as well? Or is this Are we adding the label here as well? Or is this for a different kind of label? shaktisahu 2016/10/27 02:42:56 Yea, this is the same label used above the edit te Show quoted text On 2016/10/19 16:40:30, David Trainor wrote: > Are we adding the label here as well? Or is this for a different kind of label? Yea, this is the same label used above the edit text. The text on this label will be set from Java.
	10 android:id="@+id/label"

	11 android:layout_width="match_parent"

	12 android:layout_height="wrap_content"

	13 android:layout_marginTop="17dp"

	14 android:layout_marginStart="24dp"

	15 android:textSize="12sp"/>
	David Trainor- moved to gerrit 2016/10/19 16:40:30 Should we be setting color/font/etc? Should we be setting color/font/etc? shaktisahu 2016/10/27 02:42:56 I think we should clean these up to use a few defi Show quoted text On 2016/10/19 16:40:30, David Trainor (OOO to oct 31) wrote: > Should we be setting color/font/etc? I think we should clean these up to use a few defined styles. Also the roboto fonts are supported only in newer versions. Need to define different styles for different versions. David Trainor- moved to gerrit 2016/10/28 05:08:08 Sounds good! Show quoted text On 2016/10/27 02:42:56, shaktisahu wrote: > On 2016/10/19 16:40:30, David Trainor (OOO to oct 31) wrote: > > Should we be setting color/font/etc? > > I think we should clean these up to use a few defined styles. Also the roboto > fonts are supported only in newer versions. Need to define different styles for > different versions. Sounds good!
10 <org.chromium.blimp.core.contents.input.ImeEditText	16 <org.chromium.blimp.core.contents.input.ImeEditText

11 android:id="@+id/ime_edit_text"	17 android:id="@+id/ime_edit_text"

12 android:inputType="text"	18 android:inputType="text"

13 android:layout_width="match_parent"	19 android:layout_width="match_parent"

14 android:layout_height="wrap_content"	20 android:layout_height="wrap_content"

15 android:textSize="18sp"	21 android:layout_below="@+id/label"

16 android:singleLine="true"	22 android:layout_marginTop= "4dp"

17 android:layout_marginTop="10dp"/>	23 android:layout_marginStart="24dp"

18 </FrameLayout>	24 android:layout_marginEnd="24dp"

	25 android:textSize="16sp"

	26 android:singleLine="true"/>

	27 <ProgressBar
	David Trainor- moved to gerrit 2016/10/19 16:40:30 Are we relying on the OK/CANCEL buttons from the a Are we relying on the OK/CANCEL buttons from the alert dialog, but hiding them for this? Would it be cleaner to keep both in the xml so we can eventually do the slide animations? shaktisahu 2016/10/27 02:42:56 Done. Changed to a generic dialog and moved them t Show quoted text On 2016/10/19 16:40:30, David Trainor (OOO to oct 31) wrote: > Are we relying on the OK/CANCEL buttons from the alert dialog, but hiding them > for this? Would it be cleaner to keep both in the xml so we can eventually do > the slide animations? Done. Changed to a generic dialog and moved them to a different panel. David Trainor- moved to gerrit 2016/10/28 05:08:08 I like the name :). Show quoted text On 2016/10/27 02:42:56, shaktisahu wrote: > On 2016/10/19 16:40:30, David Trainor (OOO to oct 31) wrote: > > Are we relying on the OK/CANCEL buttons from the alert dialog, but hiding them > > for this? Would it be cleaner to keep both in the xml so we can eventually do > > the slide animations? > > Done. Changed to a generic dialog and moved them to a different panel. I like the name :).
	28 android:id="@+id/submit_spinner"

	29 style="?android:attr/progressBarStyle"

	30 android:layout_width="wrap_content"

	31 android:layout_height="wrap_content"

	32 android:layout_below="@+id/ime_edit_text"

	33 android:layout_centerHorizontal="true"

	34 android:layout_marginTop="24dp"

	35 android:indeterminate="true"

	36 android:visibility="gone" />

	37 </RelativeLayout>

OLD	NEW