Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2393443002: Adjust compositing tests to be SPv2-compatible. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
Xianzhu, wkorman
CC:
blink-reviews, chromium-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust compositing tests to be SPv2-compatible. This is the first in a batch of CLs. There are a bunch of tests to adjust. Also deleted some composited selection gap tests rather than adjust them. BUG=647831 Committed: https://crrev.com/03f1c4ca97035679de96bfe79bb2da9bcaa0494c Cr-Commit-Position: refs/heads/master@{#422869}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2129 lines, -15070 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt View 1 chunk +18 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/stacking-context-overlap.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/stacking-context-overlap-expected.txt View 1 chunk +19 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-added.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-added-expected.txt View 1 chunk +9 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-overlap.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-overlap-expected.txt View 1 chunk +9 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-removed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-removed-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/ancestor-with-clip-path.html View 1 4 chunks +5 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html View 1 4 chunks +3 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/opt-in-if-composited.html View 1 4 chunks +4 lines, -15 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/overflow/resources/composited-scroll.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius.html View 1 4 chunks +3 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/selection-gaps.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/selection-gaps-after-removing-scrolling-contents.html View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/selection-gaps-expected.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/selection-gaps-toggling.html View 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/WebKit/LayoutTests/compositing/overflow/selection-gaps-toggling-with-scrolling-contents.html View 1 chunk +0 lines, -78 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/universal-accelerated-overflow-scroll.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/universal-accelerated-overflow-scroll-expected.txt View 1 chunk +1003 lines, -1135 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rendering-contexts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rendering-contexts-expected.txt View 1 chunk +28 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/composited-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/composited-layer-expected.txt View 2 chunks +3 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -502 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -375 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -502 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -502 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -375 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -502 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-expected.txt View 1 chunk +0 lines, -432 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 1 chunk +0 lines, -578 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/universal-accelerated-overflow-scroll-expected.txt View 1 1 chunk +1003 lines, -1135 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
chrishtr
4 years, 2 months ago (2016-10-03 23:45:42 UTC) #3
chrishtr
4 years, 2 months ago (2016-10-03 23:45:49 UTC) #5
Xianzhu
lgtm
4 years, 2 months ago (2016-10-04 02:46:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393443002/1
4 years, 2 months ago (2016-10-04 02:47:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/307827)
4 years, 2 months ago (2016-10-04 04:14:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2393443002/40001
4 years, 2 months ago (2016-10-04 17:47:51 UTC) #13
wkorman
lgtm https://codereview.chromium.org/2393443002/diff/40001/third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html File third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html (right): https://codereview.chromium.org/2393443002/diff/40001/third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html#newcode49 third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html:49: document.getElementById("layertree").innerText = window.internals.layerTreeAsText(document, window.internals.OUTPUT_CHILDREN_AS_LAYER_LIST); In what cases are ...
4 years, 2 months ago (2016-10-04 18:18:14 UTC) #14
chrishtr
On 2016/10/04 at 18:18:14, wkorman wrote: > lgtm > > https://codereview.chromium.org/2393443002/diff/40001/third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html > File third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html (right): ...
4 years, 2 months ago (2016-10-04 18:27:43 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 18:47:01 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:50:08 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03f1c4ca97035679de96bfe79bb2da9bcaa0494c
Cr-Commit-Position: refs/heads/master@{#422869}

Powered by Google App Engine
This is Rietveld 408576698