third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html - Issue 2393443002: Adjust compositing tests to be SPv2-compatible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html

Issue 2393443002: Adjust compositing tests to be SPv2-compatible. (Closed)

Patch Set: none Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html ('K') | « third_party/WebKit/LayoutTests/compositing/overflow/ancestor-with-clip-path.html ('k') | third_party/WebKit/LayoutTests/compositing/overflow/opt-in-if-composited.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html

diff --git a/third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html b/third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html

index 2118dba60e91d1d2ad506d66e9359f72aae39a56..82bc43cdaff133ba4f8160004c7b777c782de773 100644

--- a/third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html

+++ b/third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html

@@ -1,4 +1,5 @@

<!DOCTYPE HTML>

+<script src="resources/composited-scroll.js"></script>

<style>

#scroller {

overflow: scroll;

@@ -28,18 +29,6 @@

</div>

-function isUsingCompositedScrolling(layer) {

- if (layer.bounds[1] == 1000)

- return true;

- if (layer.children) {

- for (var i = 0; i < layer.children.length; i++) {

- if (isUsingCompositedScrolling(layer.children[i]))

- return true;

- }

- return false;

if (window.internals)

window.internals.settings.setPreferCompositingToLCDTextEnabled(true);

@@ -53,7 +42,7 @@ var result = "";

onload = function() {

if (window.internals) {

result += "No clip path descendant (should be using composited scrolling): ";

- if (isUsingCompositedScrolling(JSON.parse(window.internals.layerTreeAsText(document))))

+ if (isUsingCompositedScrolling(JSON.parse(window.internals.layerTreeAsText(document, window.internals.OUTPUT_CHILDREN_AS_LAYER_LIST))))

result += "Pass.\n";

else

result += "Fail.\n"

@@ -62,7 +51,7 @@ onload = function() {

requestAnimationFrame(function() {

if (window.internals) {

result += "Has clip path descendant (should not be using composited scrolling): ";

- if (!isUsingCompositedScrolling(JSON.parse(window.internals.layerTreeAsText(document))))

+ if (!isUsingCompositedScrolling(JSON.parse(window.internals.layerTreeAsText(document, window.internals.OUTPUT_CHILDREN_AS_LAYER_LIST))))

result += "Pass.\n";

else

result += "Fail.\n"