Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: base/debug/trace_event_win.h

Issue 23934003: Have all trace points emit to ETW. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/trace_event_win.h
diff --git a/base/debug/trace_event_win.h b/base/debug/trace_event_win.h
index 2a900bb4314f055b67a24bfea4bcdc766a569424..62194498d34ddd3d88387b390cec68f4387f936a 100644
--- a/base/debug/trace_event_win.h
+++ b/base/debug/trace_event_win.h
@@ -37,14 +37,14 @@ class BASE_EXPORT TraceEventETWProvider : public base::win::EtwTraceProvider {
static void Trace(const char* name,
size_t name_len,
char type,
- const void* id,
+ unsigned long long id,
const char* extra,
size_t extra_len);
// Allows passing extra as a std::string for convenience.
static void Trace(const char* name,
char type,
- const void* id,
+ unsigned long long id,
const std::string& extra) {
return Trace(name, -1, type, id, extra.c_str(), extra.length());
}
@@ -53,7 +53,7 @@ class BASE_EXPORT TraceEventETWProvider : public base::win::EtwTraceProvider {
// std::string instances where not needed.
static void Trace(const char* name,
char type,
- const void* id,
+ unsigned long long id,
const char* extra) {
return Trace(name, -1, type, id, extra, -1);
}
@@ -75,7 +75,7 @@ class BASE_EXPORT TraceEventETWProvider : public base::win::EtwTraceProvider {
void TraceEvent(const char* name,
size_t name_len,
char type,
- const void* id,
+ unsigned long long id,
const char* extra,
size_t extra_len);

Powered by Google App Engine
This is Rietveld 408576698