Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8380)

Unified Diff: base/debug/trace_event_win.cc

Issue 23934003: Have all trace points emit to ETW. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/debug/trace_event_impl.cc ('K') | « base/debug/trace_event_win.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event_win.cc
diff --git a/base/debug/trace_event_win.cc b/base/debug/trace_event_win.cc
index d5a21f49268f3b386a94e6d4d06d1fb57db1faeb..5caca343389516be44867e1f94878c8363a8188e 100644
--- a/base/debug/trace_event_win.cc
+++ b/base/debug/trace_event_win.cc
@@ -43,7 +43,7 @@ bool TraceEventETWProvider::StartTracing() {
void TraceEventETWProvider::TraceEvent(const char* name,
size_t name_len,
char type,
- const void* id,
+ unsigned long long id,
const char* extra,
size_t extra_len) {
// Make sure we don't touch NULL.
@@ -97,7 +97,7 @@ void TraceEventETWProvider::TraceEvent(const char* name,
void TraceEventETWProvider::Trace(const char* name,
size_t name_len,
char type,
- const void* id,
+ unsigned long long id,
chrisha 2013/09/04 13:32:09 Why are we changing the type of this?
fdoray 2013/09/05 20:10:31 I wanted to avoid an extra type conversion: |id| c
const char* extra,
size_t extra_len) {
TraceEventETWProvider* provider = TraceEventETWProvider::GetInstance();
« base/debug/trace_event_impl.cc ('K') | « base/debug/trace_event_win.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698