Have all trace points emit to ETW.

base/debug/trace_event_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #include "base/debug/trace_event_win.h"
 
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include <initguid.h>  // NOLINT
 
 namespace base {
@@ skipping 25 matching lines @@
       StaticMemorySingletonTraits<TraceEventETWProvider> >::get();
 }
 
 bool TraceEventETWProvider::StartTracing() {
   return true;
 }
 
 void TraceEventETWProvider::TraceEvent(const char* name,
                                        size_t name_len,
                                        char type,
-                                       const void* id,
+                                       unsigned long long id,
                                        const char* extra,
                                        size_t extra_len) {
   // Make sure we don't touch NULL.
   if (name == NULL)
     name = "";
   if (extra == NULL)
     extra = "";
 
   EtwEventType etw_type = 0;
   switch (type) {
@@ skipping 33 matching lines @@
     event.SetField(4, sizeof(backtrace[0]) * depth, backtrace);
   }
 
   // Trace the event.
   Log(event.get());
 }
 
 void TraceEventETWProvider::Trace(const char* name,
                                   size_t name_len,
                                   char type,
-                                  const void* id,
+                                  unsigned long long id,

[chrisha, 2013/09/04 13:32:09]

Why are we changing the type of this?

[fdoray, 2013/09/05 20:10:31]

I wanted to avoid an extra type conversion: |id| comes from
TraceLog::AddTraceEventWithThreadIdAndTimestamp, which uses an "unsigned long
long". |id| can also come from the TRACE_EVENT_*_ETW macros (via
base::debug::TraceLog::AddTraceEventEtw), but I understand from crbug.com/81584
that these macros will disappear.

Sawbuck had trouble displaying |extra| when I used an "unsigned long long" so I
will keep a "const void*" for now.

On 2013/09/04 13:32:09, chrisha wrote:

                                   const char* extra,
                                   size_t extra_len) {
   TraceEventETWProvider* provider = TraceEventETWProvider::GetInstance();
   if (provider && provider->IsTracing()) {
     // Compute the name & extra lengths if not supplied already.
     if (name_len == -1)
       name_len = (name == NULL) ? 0 : strlen(name);
     if (extra_len == -1)
       extra_len = (extra == NULL) ? 0 : strlen(extra);
 
     provider->TraceEvent(name, name_len, type, id, extra, extra_len);

[chrisha, 2013/09/04 13:32:09]

TraceEvent takes a const void * too, no? There's a type size mismatch here.

   }
 }
 
 void TraceEventETWProvider::Resurrect() {
   StaticMemorySingletonTraits<TraceEventETWProvider>::Resurrect();
 }
 
 }  // namespace debug
 }  // namespace base