gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

Extend the GPU workaround exception list to enable CMAA on all Braswell,
Broadwell and Skylake GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

This patch changes the way the platform filtering is done. Intead of
"device_id", "gl_renderer" is used.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/47347f7cbee3bb0b1f6fec119281c2bcd23ef617
Cr-Commit-Position: refs/heads/master@{#424156}

[adrian.belgun, 2016-10-06 12:20:03]

adrian.belgun@intel.com changed reviewers:
+ dongseong.hwang@intel.com, kbr@chromium.org, marcheu@chromium.org,
robert.bradford@intel.com

[adrian.belgun, 2016-10-06 12:20:04]

Hello! 

marcheu@, kbr@ please review.

This patch simplifies the way platform filtering is done for CMAA enablement,
based upon the "gl_render" string instead of the "device_id".

Source of render names:
https://cgit.freedesktop.org/mesa/mesa/tree/include/pci_ids/i965_pci_ids.h
 
This also enables CMAA in Skylake Chromebooks.

Thank you,
Adrian.

[adrian.belgun, 2016-10-06 12:25:06]

Description was changed from

==========
gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

Extend the GPU workaround exception list to enable CMAA on all Braswell,
Broadwell and Skylake GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

This patch changes the way the platform filtering is done. Intead of
"device_id", "gl_renderer" is used.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

Extend the GPU workaround exception list to enable CMAA on all Braswell,
Broadwell and Skylake GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

This patch changes the way the platform filtering is done. Intead of
"device_id", "gl_renderer" is used.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[adrian.belgun, 2016-10-06 12:25:07]

adrian.belgun@intel.com changed required reviewers:
+ kbr@chromium.org, marcheu@chromium.org

[Ken Russell (switch to Gerrit), 2016-10-07 02:10:21]

CC'ing zmo@ and j.isorce@ who have run into the mentioned issue recently.

This basically LGTM as long as it's been tested.

https://codereview.chromium.org/2393323003/diff/20001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2393323003/diff/20001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:1791: "gl_renderer":
".*Intel.*(Braswell|Broadwell|Skylake).*",
Have you tested this? There are bootstrapping problems with basing blacklist
entries on the GL_VENDOR and GL_RENDERER strings on some platforms (though none
affected by this blacklist entry -- basically macOS).

[adrian.belgun, 2016-10-07 06:22:35]

https://codereview.chromium.org/2393323003/diff/20001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2393323003/diff/20001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:1791: "gl_renderer":
".*Intel.*(Braswell|Broadwell|Skylake).*",
On 2016/10/07 02:10:21, Ken Russell wrote:
> Have you tested this? There are bootstrapping problems with basing blacklist
> entries on the GL_VENDOR and GL_RENDERER strings on some platforms (though
none
> affected by this blacklist entry -- basically macOS).

This was tested on a Broadwell Linux device and it functions as expected:
- stock: no cmaa (os is linux)
- with the "os" field commented: no cmaa (linux used opengl not opengl es)
- with the "os" field commented and the "-use-gl=egl" flag: cmaa works
- with the "os" field commented, the "-use-gl=egl" flag and "Broadwell" removed
from the regexp: no cmaa

At this point we're targeting enablement on Gen8(1) hardware and above on
ChromeOS and possibly Linux in the future. Thus we're only looking at Mesa as
driver back-end. 

On Mesa the the gl_render(2) names are consistently defined from the pci_ids.

I'm planning to land this once the rest of the testing is done.
I will be doing additional testing on falco (cmaa should not be enabled), cyan
(cmaa should work) and on lulu (cmaa should work).

Regarding MacOS, no testing was done at this point in time, but we're currently
filtering on os == chromeos, so it should not be affected.

1: https://en.wikipedia.org/wiki/Intel_HD_and_Iris_Graphics#Capabilities
2: https://cgit.freedesktop.org/mesa/mesa/tree/include/pci_ids/i965_pci_ids.h

[Ken Russell (switch to Gerrit), 2016-10-07 18:54:48]

Thanks for the info. Still LGTM.

[dshwang, 2016-10-10 10:15:23]

lgtm. now much better maintainable!

[adrian.belgun, 2016-10-10 13:52:22]

adrian.belgun@intel.com changed required reviewers:
- marcheu@chromium.org

[adrian.belgun, 2016-10-10 13:52:30]

The CQ bit was checked by adrian.belgun@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 13:52:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 14:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 14:48:02]

Dry run: This issue passed the CQ dry run.

[adrian.belgun, 2016-10-10 15:37:30]

The CQ bit was checked by adrian.belgun@intel.com

[commit-bot: I haz the power, 2016-10-10 15:37:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 15:43:01]

Description was changed from

==========
gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

Extend the GPU workaround exception list to enable CMAA on all Braswell,
Broadwell and Skylake GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

This patch changes the way the platform filtering is done. Intead of
"device_id", "gl_renderer" is used.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

Extend the GPU workaround exception list to enable CMAA on all Braswell,
Broadwell and Skylake GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

This patch changes the way the platform filtering is done. Intead of
"device_id", "gl_renderer" is used.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-10 15:43:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-10 15:44:51]

Description was changed from

==========
gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

Extend the GPU workaround exception list to enable CMAA on all Braswell,
Broadwell and Skylake GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

This patch changes the way the platform filtering is done. Intead of
"device_id", "gl_renderer" is used.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

Extend the GPU workaround exception list to enable CMAA on all Braswell,
Broadwell and Skylake GPUs. Using CMAA in place of MSAA for WebGL gives a
performance benefit.

This patch changes the way the platform filtering is done. Intead of
"device_id", "gl_renderer" is used.

BUG=535198
TEST=Boot cyan and observe that workaround is no longer listed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/47347f7cbee3bb0b1f6fec119281c2bcd23ef617
Cr-Commit-Position: refs/heads/master@{#424156}
==========

[commit-bot: I haz the power, 2016-10-10 15:44:52]

Patchset 2 (id:??) landed as
https://crrev.com/47347f7cbee3bb0b1f6fec119281c2bcd23ef617
Cr-Commit-Position: refs/heads/master@{#424156}