gpu: Enable CMAA for all Braswell, Broadwell and Skylake ChromeOS devices

gpu/config/gpu_driver_bug_list_json.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Determines whether a certain driver bug exists in the current system.
 // The format of a valid gpu_driver_bug_list.json file is defined in
 // <gpu/config/gpu_control_list_format.txt>.
 // The supported "features" can be found in
 // <gpu/config/gpu_driver_bug_workaround_type.h>.
 
 #include "gpu/config/gpu_control_list_jsons.h"
 
 #define LONG_STRING_CONST(...) #__VA_ARGS__
 
 namespace gpu {
 
 const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
 
 {
   "name": "gpu driver bug list",
   // Please update the version number whenever you change this file.
-  "version": "9.04",
+  "version": "9.05",
   "entries": [
     {
       "id": 1,
       "description": "Imagination driver doesn't like uploading lots of buffer data constantly",
       "os": {
         "type": "android"
       },
       "gl_vendor": "Imagination.*",
       "features": [
         "use_client_side_arrays_for_stream_buffers"
@@ skipping 1746 matching lines @@
     {
       "id": 172,
       "description": "Limited enabling of Chromium GL_INTEL_framebuffer_CMAA",
       "cr_bugs": [535198],
       "exceptions" : [
         {
           "os": {
             "type" : "chromeos"
           },
           "vendor_id": "0x8086",
-          "device_id": ["0x1602", "0x1606", "0x160a", "0x160b", "0x160d",
-                        "0x160e", "0x1612", "0x1616", "0x161a", "0x161b",
-                        "0x161d", "0x161e", "0x1622", "0x1626", "0x162a",
-                        "0x162b", "0x162d", "0x162e", "0x22b0", "0x22b1",
-                        "0x22b2", "0x22b3"]
+          "driver_vendor": "Mesa",
+          "gl_vendor": "Intel.*",
+          "gl_renderer": ".*Intel.*(Braswell|Broadwell|Skylake).*",

[Ken Russell (switch to Gerrit), 2016/10/07 02:10:21]

Have you tested this? There are bootstrapping problems with basing blacklist
entries on the GL_VENDOR and GL_RENDERER strings on some platforms (though none
affected by this blacklist entry -- basically macOS).

[adrian.belgun, 2016/10/07 06:22:35]

This was tested on a Broadwell Linux device and it functions as expected:
- stock: no cmaa (os is linux)
- with the "os" field commented: no cmaa (linux used opengl not opengl es)
- with the "os" field commented and the "-use-gl=egl" flag: cmaa works
- with the "os" field commented, the "-use-gl=egl" flag and "Broadwell" removed
from the regexp: no cmaa

At this point we're targeting enablement on Gen8(1) hardware and above on
ChromeOS and possibly Linux in the future. Thus we're only looking at Mesa as
driver back-end. 

On Mesa the the gl_render(2) names are consistently defined from the pci_ids.

I'm planning to land this once the rest of the testing is done.
I will be doing additional testing on falco (cmaa should not be enabled), cyan
(cmaa should work) and on lulu (cmaa should work).

Regarding MacOS, no testing was done at this point in time, but we're currently
filtering on os == chromeos, so it should not be affected.

1: https://en.wikipedia.org/wiki/Intel_HD_and_Iris_Graphics#Capabilities
2: https://cgit.freedesktop.org/mesa/mesa/tree/include/pci_ids/i965_pci_ids.h

+          "gl_type": "gles",
+          "gl_version": {
+            "op": ">=",
+            "value": "3.1"
+          }
         }
       ],
       "features": [
         "disable_framebuffer_cmaa"
       ]
     },
     {
       "id": 174,
       "description": "Adreno 4xx support for EXT_multisampled_render_to_texture is buggy on Android 7.0",
       "cr_bugs": [612474],
@@ skipping 225 matching lines @@
       ]
     }
   ]
   // Please update the version number at beginning of this file whenever you
   // change this file.
 }
 
 );  // LONG_STRING_CONST macro
 
 }  // namespace gpu