Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2392863002: Roll kernel to latest (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll kernel to latest + fix default constructor encoding + match fall-through error handling + handle typedef tests + speed up visitor_test by reusing the Compiler object R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/1b2e857f19d8876ebac007059a51300a557a7724

Patch Set 1 #

Patch Set 2 : Reinsert code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -134 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/kernel_task.dart View 1 2 chunks +13 lines, -3 lines 0 comments Download
D pkg/compiler/lib/src/kernel/fall_through_visitor.dart View 1 chunk +0 lines, -99 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 3 chunks +21 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 5 chunks +34 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +9 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 9 chunks +60 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/visitor_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-10-04 09:39:07 UTC) #2
Harry Terkelsen
lgtm
4 years, 2 months ago (2016-10-04 16:04:22 UTC) #3
Johnni Winther
4 years, 2 months ago (2016-10-05 08:36:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1b2e857f19d8876ebac007059a51300a557a7724 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698