Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2392863002: Roll kernel to latest (Closed)
Patch Set: Reinsert code Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_visitor.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index e5f3477e38d8f85eb02396c7d4cb2c4836a827e9..9fb5495a263d791b6bbe0190fd8af48b046d14ed 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -4602,6 +4602,15 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
reporter.reportErrorMessage(
switchCase, MessageKind.INVALID_CASE_DEFAULT);
}
+ if (cases.isNotEmpty) {
+ Node last = switchCase.statements.last;
+ if (last.asBreakStatement() == null &&
+ last.asContinueStatement() == null &&
+ last.asThrow() == null &&
+ last.asReturn() == null) {
+ registry.registerFeature(Feature.FALL_THROUGH_ERROR);
+ }
+ }
}
addDeferredAction(enclosingElement, () {
@@ -4623,7 +4632,6 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
});
// TODO(15575): We should warn if we can detect a fall through
// error.
- registry.registerFeature(Feature.FALL_THROUGH_ERROR);
return const NoneResult();
}
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_visitor.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698