Disable local fallback in goma staging environment

Disable local fallback in goma staging environment

When rolling new server, starting goma fails sometimes due to timing issue.

* rename goma_canary -> goma_failfast in config

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/build/+/32eebb8c482d73dbc453dfdce62e46d4c8ee19a1

[tikuta, 2016-10-04 08:17:05]

tikuta@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, shinyak@chromium.org, ukai@chromium.org,
yyanagisawa@chromium.org

[shinyak, 2016-10-04 08:25:14]

https://codereview.chromium.org/2392853002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2392853002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/config.py:256: c.compile_py.goma_canary =
True
Hmm... why goma_canary?

(I feel setting c.compile_py.goma_canary enables --goma-disable-local-fallback
is not intuitive.)

[tikuta, 2016-10-04 08:37:01]

Description was changed from

==========
Disable local fallback in goma staging environment

When rolling new server, starting goma fails sometimes due to timing issue.

BUG=
==========

to

==========
Disable local fallback in goma staging environment

When rolling new server, starting goma fails sometimes due to timing issue.

* rename goma_canary -> goma_failfast in config

BUG=
==========

[tikuta, 2016-10-04 08:37:42]

https://codereview.chromium.org/2392853002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2392853002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/config.py:256: c.compile_py.goma_canary =
True
On 2016/10/04 08:25:14, shinyak wrote:
> Hmm... why goma_canary?
> 
> (I feel setting c.compile_py.goma_canary enables --goma-disable-local-fallback
> is not intuitive.)

yeah, I renamed.

[Paweł Hajdan Jr., 2016-10-04 09:12:16]

LGTM

[tikuta, 2016-10-04 09:19:47]

The CQ bit was checked by tikuta@chromium.org

[commit-bot: I haz the power, 2016-10-04 09:19:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 09:23:52]

Description was changed from

==========
Disable local fallback in goma staging environment

When rolling new server, starting goma fails sometimes due to timing issue.

* rename goma_canary -> goma_failfast in config

BUG=
==========

to

==========
Disable local fallback in goma staging environment

When rolling new server, starting goma fails sometimes due to timing issue.

* rename goma_canary -> goma_failfast in config

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/32eebb8c482d73dbc453...
==========

[commit-bot: I haz the power, 2016-10-04 09:23:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/32eebb8c482d73dbc453...

[Yoshisato Yanagisawa, 2016-10-04 09:31:08]

https://codereview.chromium.org/2392853002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/2392853002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/api.py:218: if
self.c.compile_py.goma_failfast:
I feel this confusing because there is --goma-fail-fast option (please see 5
lines below), and this actually does not set that.

[tikuta, 2016-10-04 10:36:22]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2390723004/ by tikuta@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.goma/builders/Chromium%20Linux%20Goma%2...

compile.py with disable_local_fallback does not stop compile when compiler_proxy
fails to ping server..