scripts/slave/recipe_modules/chromium/api.py - Issue 2392853002: Disable local fallback in goma staging environment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2392853002: Disable local fallback in goma staging environment (Closed)

Patch Set: goma_canary -> goma_failfast Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index d709175717da6963c05988630ac71c7aa7b37e62..afb41e169f42e415a36b8ac9de2b0e9d840db610 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -215,7 +215,7 @@ class ChromiumApi(recipe_api.RecipeApi):

args += ['--goma-enable-remote-link']

if self.c.compile_py.goma_store_local_run_output:

args += ['--goma-store-local-run-output']

- if self.c.compile_py.goma_canary:

+ if self.c.compile_py.goma_failfast:

Yoshisato Yanagisawa 2016/10/04 09:31:07 I feel this confusing because there is --goma-fail

args += ['--goma-disable-local-fallback']

if self.m.tryserver.is_tryserver:

# We rely on goma to meet cycle time goals on the tryserver. It's better

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/config.py » ('j') | no next file with comments »