Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2392603003: [Merge-M54] arc: Show icon for the task created in background. (Closed)

Created:
4 years, 2 months ago by khmel
Modified:
4 years, 2 months ago
Reviewers:
reviewer
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge-M54] arc: Show icon for the task created in background. There is support for Arc tasks which don't have window on creation time. TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true BUG=b/31780038 BUG=651225 TEST=Manually on device. Various cases with deferred launch, pinned non-pinned apps, switch to secondary user profile and back. In all cases we have shelf icon for apps, even if another Arc app is active in full screen. In case of switching to the secondary profile, there is no Arc icons, including those, which don't have window attached. Review-Url: https://codereview.chromium.org/2381713002 Cr-Commit-Position: refs/heads/master@{#421833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -23 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 5 chunks +54 lines, -22 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392603003/1
4 years, 2 months ago (2016-10-03 20:32:24 UTC) #2
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:35:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698