Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 2381713002: arc: Show icon for the task created in background. (Closed)

Created:
4 years, 2 months ago by khmel
Modified:
4 years, 2 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Show icon for the task created in background. There is support for Arc tasks which don't have window on creation time. BUG=b/31780038 BUG=651225 TEST=Manually on device. Various cases with deferred launch, pinned non-pinned apps, switch to secondary user profile and back. In all cases we have shelf icon for apps, even if another Arc app is active in full screen. In case of switching to the secondary profile, there is no Arc icons, including those, which don't have window attached. Committed: https://crrev.com/4f5fe26dc3419d1fc7bc691e433d42eef7b1f8ce Cr-Commit-Position: refs/heads/master@{#421833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -23 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 5 chunks +54 lines, -22 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
khmel
Hi Stefan, PTAL
4 years, 2 months ago (2016-09-28 22:48:50 UTC) #2
Mr4D (OOO till 08-26)
lgtm. Somehow I still wonder if we haven't forgotten something. I get the feeling that ...
4 years, 2 months ago (2016-09-29 03:16:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381713002/1
4 years, 2 months ago (2016-09-29 15:30:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 16:03:15 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 16:06:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f5fe26dc3419d1fc7bc691e433d42eef7b1f8ce
Cr-Commit-Position: refs/heads/master@{#421833}

Powered by Google App Engine
This is Rietveld 408576698