src/bootstrapper.h - Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.h

Issue 239243018: Heap::AllocateStringFromOneByte() and major part of its callers handlified. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressing comment + some cleanup Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.h

diff --git a/src/bootstrapper.h b/src/bootstrapper.h

index 6dea116a58245f182c8fb4af4b66530728c0a02b..f6fcd02ef62e088e2187bafc7dfafff28d59c8e3 100644

--- a/src/bootstrapper.h

+++ b/src/bootstrapper.h

@@ -47,7 +47,8 @@ class SourceCodeCache V8_FINAL BASE_EMBEDDED {

Handle<FixedArray> new_array = factory->NewFixedArray(length + 2, TENURED);

cache_->CopyTo(0, *new_array, 0, cache_->length());

cache_ = *new_array;

- Handle<String> str = factory->NewStringFromAscii(name, TENURED);

+ Handle<String> str =

+ factory->NewStringFromAscii(name, TENURED).ToHandleChecked();

ASSERT(!str.is_null());

cache_->set(length, *str);

cache_->set(length + 1, *shared);

« no previous file with comments | « src/ast.cc ('k') | src/bootstrapper.cc » ('j') | no next file with comments »