Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2392343007: Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:20… (Closed)

Created:
4 years, 2 months ago by hubbe
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2882
Project:
chromium
Visibility:
Public.

Description

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=653388 Original issue's description: > Attach color space information to hardware decoded NV12 video frames. > > This extracts the color information from the h264 stream and attaches > it to the video frame. Currently this is only done if the result is > NV12 as we don't have the code yet to do it for RGB frames. > > BUG=622133, 647725 > > Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb > Cr-Commit-Position: refs/heads/master@{#422942} TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622133, 647725 Review-Url: https://codereview.chromium.org/2399133002 Cr-Commit-Position: refs/heads/master@{#423605} (cherry picked from commit c5d6ad8849efdb60d7d42d540997b36a144b8797) Committed: https://chromium.googlesource.com/chromium/src/+/a65782c053825f9f287b1c5d09fc9804aa8af451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -159 lines) Patch
M content/renderer/pepper/video_decoder_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/h264_parser.h View 3 chunks +0 lines, -10 lines 0 comments Download
M media/filters/h264_parser.cc View 2 chunks +7 lines, -29 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.h View 2 chunks +0 lines, -6 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 6 chunks +4 lines, -15 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 14 chunks +18 lines, -36 lines 0 comments Download
M media/gpu/fake_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/ipc/client/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.h View 2 chunks +5 lines, -4 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M media/gpu/ipc/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/common/media_messages.h View 3 chunks +6 lines, -12 lines 0 comments Download
M media/gpu/ipc/service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/v4l2_video_decode_accelerator.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/video/picture.h View 4 chunks +0 lines, -6 lines 0 comments Download
M media/video/picture.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits_macros.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hubbe
4 years, 2 months ago (2016-10-06 19:03:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a65782c053825f9f287b1c5d09fc9804aa8af451.

Powered by Google App Engine
This is Rietveld 408576698