Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2195)

Issue 2399133002: Revert of Attach color space information to hardware decoded NV12 video frames. (Closed)

Created:
4 years, 2 months ago by hubbe
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Attach color space information to hardware decoded NV12 video frames. (patchset #11 id:200001 of https://codereview.chromium.org/2345123002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=653388 Original issue's description: > Attach color space information to hardware decoded NV12 video frames. > > This extracts the color information from the h264 stream and attaches > it to the video frame. Currently this is only done if the result is > NV12 as we don't have the code yet to do it for RGB frames. > > BUG=622133, 647725 > > Committed: https://crrev.com/b213e899246050d799ccb6df0e40837b619da8fb > Cr-Commit-Position: refs/heads/master@{#422942} TBR=sandersd@chromium.org,posciak@chromium.org,jbauman@chromium.org,bbudge@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622133, 647725 Committed: https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797 Cr-Commit-Position: refs/heads/master@{#423605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -161 lines) Patch
M content/renderer/pepper/video_decoder_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/h264_parser.h View 3 chunks +0 lines, -10 lines 0 comments Download
M media/filters/h264_parser.cc View 2 chunks +7 lines, -29 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/dxva_picture_buffer_win.h View 2 chunks +0 lines, -6 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.h View 6 chunks +4 lines, -15 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 14 chunks +20 lines, -38 lines 0 comments Download
M media/gpu/fake_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/ipc/client/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.h View 2 chunks +5 lines, -4 lines 0 comments Download
M media/gpu/ipc/client/gpu_video_decode_accelerator_host.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M media/gpu/ipc/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/common/media_messages.h View 3 chunks +6 lines, -12 lines 0 comments Download
M media/gpu/ipc/service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/gpu/ipc/service/gpu_video_decode_accelerator.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M media/gpu/v4l2_slice_video_decode_accelerator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/gpu/v4l2_video_decode_accelerator.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M media/gpu/vaapi_video_decode_accelerator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M media/gpu/vt_video_decode_accelerator_mac.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/video/picture.h View 4 chunks +0 lines, -6 lines 0 comments Download
M media/video/picture.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits_macros.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
hubbe
Created Revert of Attach color space information to hardware decoded NV12 video frames.
4 years, 2 months ago (2016-10-06 18:24:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399133002/1
4 years, 2 months ago (2016-10-06 18:25:14 UTC) #3
Tom Sepez
RS LGTM
4 years, 2 months ago (2016-10-06 18:26:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/275581)
4 years, 2 months ago (2016-10-06 18:38:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399133002/1
4 years, 2 months ago (2016-10-06 18:46:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 18:47:53 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 18:49:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5d6ad8849efdb60d7d42d540997b36a144b8797
Cr-Commit-Position: refs/heads/master@{#423605}

Powered by Google App Engine
This is Rietveld 408576698