Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2392343005: Reflow comments in core/css (Closed)

Created:
4 years, 2 months ago by meade_UTC10
Modified:
4 years, 2 months ago
Reviewers:
Timothy Loh, Nico
CC:
chromium-reviews, kenneth.christiansen, jfernandez, blink-reviews-style_chromium.org, svillar, blink-reviews-css, Manuel Rego, Yoav Weiss, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in core/css Note that some ASSERTs became DCHECKs, and some bitfields became unsigned instead of uint16_t, because I reflowed a comment next to them. BUG=563793 Committed: https://crrev.com/69b89efbfc2bbb21182ed1407b1cf467f5add3df Cr-Commit-Position: refs/heads/master@{#423514}

Patch Set 1 #

Patch Set 2 : Manually reflow, update DCHECK #

Patch Set 3 : Revert subdirs #

Patch Set 4 : Revert clang-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, -548 lines) Patch
M third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp View 1 6 chunks +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSBorderImageSliceValue.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCalculationValue.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCalculationValue.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 1 3 chunks +25 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCursorImageValue.cpp View 1 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCustomIdentValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSource.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSourceTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontSelector.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 1 20 chunks +58 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGridAutoRepeatValue.h View 1 1 chunk +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGroupingRule.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSIdentifierValue.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImportRule.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSMarkup.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSMarkup.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSMatrix.h View 1 1 chunk +23 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSMatrix.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h View 1 5 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 3 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperty.h View 1 chunk +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp View 1 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPropertySourceData.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp View 1 2 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.h View 1 6 chunks +41 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 1 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleDeclaration.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleSheet.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSyntaxDescriptor.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp View 1 3 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueList.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSVariableData.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 17 chunks +51 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/css/ElementRuleCollector.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/ElementRuleCollector.cpp View 1 6 chunks +22 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 1 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontSize.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontSize.cpp View 1 6 chunks +29 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontStyleMatcher.cpp View 2 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/HashTools.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaList.cpp View 1 2 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQuery.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp View 1 5 chunks +14 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryExp.cpp View 1 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryList.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaQueryMatcher.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaValues.cpp View 1 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaValuesCached.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/MediaValuesCached.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/MediaValuesDynamic.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/PageRuleCollector.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/PageRuleCollector.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/PropertyRegistration.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/PseudoStyleRequest.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RemoteFontFaceSource.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 5 chunks +19 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.h View 1 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 1 4 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 24 chunks +62 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorFilter.h View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorFilter.cpp View 1 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySerializer.cpp View 1 9 chunks +21 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 1 6 chunks +16 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertyShorthandCustom.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRuleImport.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 1 12 chunks +43 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetList.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
meade_UTC10
4 years, 2 months ago (2016-10-06 07:48:55 UTC) #3
Timothy Loh
stamp lgtm
4 years, 2 months ago (2016-10-06 08:19:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392343005/60001
4 years, 2 months ago (2016-10-06 13:55:04 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-06 14:04:32 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 14:06:34 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/69b89efbfc2bbb21182ed1407b1cf467f5add3df
Cr-Commit-Position: refs/heads/master@{#423514}

Powered by Google App Engine
This is Rietveld 408576698