Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Issue 2392253002: Use list_dart_files.py instead of list_files.py in GN build. (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use list_dart_files.py instead of list_files.py in GN build. To track https://codereview.chromium.org/2391863002/ on the gyp side, and use it in more places. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ee21a2261d68e3f2bcbccb204f50d921269c64d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -44 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/BUILD.gn View 4 chunks +10 lines, -11 lines 0 comments Download
M utils/compiler/BUILD.gn View 1 chunk +13 lines, -9 lines 0 comments Download
M utils/create_timestamp.gni View 2 chunks +6 lines, -4 lines 0 comments Download
M utils/dartanalyzer/BUILD.gn View 1 chunk +6 lines, -9 lines 0 comments Download
M utils/dartdevc/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M utils/dartdoc/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M utils/dartfmt/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 2 months ago (2016-10-05 05:09:55 UTC) #3
Cutch
lgtm
4 years, 2 months ago (2016-10-05 13:53:22 UTC) #4
zra
4 years, 2 months ago (2016-10-05 14:50:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee21a2261d68e3f2bcbccb204f50d921269c64d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698