Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: utils/create_timestamp.gni

Issue 2392253002: Use list_dart_files.py instead of list_files.py in GN build. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/compiler/BUILD.gn ('k') | utils/dartanalyzer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/create_timestamp.gni
diff --git a/utils/create_timestamp.gni b/utils/create_timestamp.gni
index eb711aebe904302a9dfc519803dc5b54b5d9d035..fce5c30e6a95d0aa1a7d902e9daf7ebaa997881c 100644
--- a/utils/create_timestamp.gni
+++ b/utils/create_timestamp.gni
@@ -5,7 +5,6 @@
_dart_root = rebase_path("..")
template("create_timestamp_file") {
- assert(defined(invoker.pattern), "Must specify 'pattern'")
assert(defined(invoker.path), "Must specify 'path'")
assert(defined(invoker.output), "Must specify 'output'")
new_base = "."
@@ -16,13 +15,16 @@ template("create_timestamp_file") {
if (defined(invoker.current_base)) {
current_base = invoker.current_base
}
- pattern = invoker.pattern
path = invoker.path
output = invoker.output
action(target_name) {
+ list_args = [path]
+ if (defined(invoker.pattern)) {
+ list_args += [invoker.pattern]
+ }
files = exec_script(
- "$_dart_root/tools/list_files.py", [pattern, path], "list lines")
- inputs = ["$_dart_root/tools/list_files.py"] +
+ "$_dart_root/tools/list_dart_files.py", list_args, "list lines")
+ inputs = ["$_dart_root/tools/list_dart_files.py"] +
rebase_path(files, new_base, current_base)
outputs = [ output ]
script = "$_dart_root/tools/create_timestamp_file.py"
« no previous file with comments | « utils/compiler/BUILD.gn ('k') | utils/dartanalyzer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698