[MD settings] change protocol handler icon

[MD settings] change protocol handler icon

This CL adds a new protocol-handler icon and removes the open-with icon
that was previously used for the protocol handler.

BUG=652025
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f
Cr-Commit-Position: refs/heads/master@{#423329}

[dschuyler, 2016-10-04 21:13:27]

Description was changed from

==========
[MD settings] change protocol handler icon

This CL adds a new protocol-handler icon and removes the open-with icon
that was previously used for the protocol handler.

BUG=652025
==========

to

==========
[MD settings] change protocol handler icon

This CL adds a new protocol-handler icon and removes the open-with icon
that was previously used for the protocol handler.

BUG=652025
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-04 21:13:29]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 21:14:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-04 21:14:28]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[dschuyler, 2016-10-04 21:14:29]

The bug has a screen shot of the new icon in context.

[dschuyler, 2016-10-04 22:56:23]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 22:56:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-04 22:57:20]

Optimized some icons.

[commit-bot: I haz the power, 2016-10-05 00:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 00:55:57]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-05 01:32:49]

https://codereview.chromium.org/2392163002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/images/arrow_right.svg (right):

https://codereview.chromium.org/2392163002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/images/arrow_right.svg:1: <svg
xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"
fill="#757575"><path d="M10 7l5 5-5 5z"/></svg>
How about simplifying the path, to start from 0 0 instead (I did this with
arrow_down.svg at https://codereview.chromium.org/2384273005). Is there a
benefit from not starting from 0 0 (perhaps easier to rotate with css
transform)?

[Dan Beam, 2016-10-05 01:36:18]

dbeam@chromium.org changed reviewers:
+ dpapad@chromium.org
- dbeam@chromium.org

[Dan Beam, 2016-10-05 01:36:19]

it'd be nice if we could have an arrow_down.svg (as that's what dpapad@ needs)
and a transform: rotate(90deg) or 270deg (for RTL) for Dave's needs

moving dpapad@ to reviewer

[dpapad, 2016-10-05 22:29:15]

On 2016/10/05 at 01:36:19, dbeam wrote:
> it'd be nice if we could have an arrow_down.svg (as that's what dpapad@ needs)
and a transform: rotate(90deg) or 270deg (for RTL) for Dave's needs
> 
> moving dpapad@ to reviewer

LGTM
Chatted a bit with @dschuyler about this. It sounds nice to have one SVG that
can serve both our needs, but separating our tasks so that we don't block each
other sounds better. Even if we don't get to unify our arrow_*.svg files, the
size cost is minimal. Having said that, as part of making the native <select>
arrow look identical to the right arrow, I will experiment with rotating the
same image resource.

[dschuyler, 2016-10-05 22:54:31]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-10-05 22:55:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 23:04:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 23:08:33]

Description was changed from

==========
[MD settings] change protocol handler icon

This CL adds a new protocol-handler icon and removes the open-with icon
that was previously used for the protocol handler.

BUG=652025
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] change protocol handler icon

This CL adds a new protocol-handler icon and removes the open-with icon
that was previously used for the protocol handler.

BUG=652025
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f
Cr-Commit-Position: refs/heads/master@{#423329}
==========

[commit-bot: I haz the power, 2016-10-05 23:08:35]

Patchset 2 (id:??) landed as
https://crrev.com/e5f72054f57d109136d3cb9ce4162f8793cbed8f
Cr-Commit-Position: refs/heads/master@{#423329}