Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2392143002: reflow comments in core/style (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/style BUG=563793 Committed: https://crrev.com/566600aa3bb9d95b58e8824c50abd5a3c1657dd2 Cr-Commit-Position: refs/heads/master@{#423145}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -303 lines) Patch
M third_party/WebKit/Source/core/style/BorderImageLength.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderValue.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/CachedUAStyle.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 22 chunks +97 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 22 chunks +83 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 11 chunks +26 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/style/ContentData.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ContentData.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/FillLayer.h View 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/FillLayer.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/FilterOperation.h View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/FilterOperation.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/GridLength.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridPosition.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridPositionsResolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/GridPositionsResolver.cpp View 13 chunks +35 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridTrackSize.h View 1 chunk +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/style/NinePieceImage.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/NinePieceImage.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyle.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyle.cpp View 4 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/SVGComputedStyleTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/ShadowData.h View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ShadowData.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleContentAlignmentData.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleDifference.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFlexibleBoxData.h View 1 1 chunk +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFlexibleBoxData.cpp View 1 1 chunk +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGridData.h View 1 3 chunks +16 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGridData.cpp View 1 1 chunk +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 3 chunks +18 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleSelfAlignmentData.h View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Nico
4 years, 2 months ago (2016-10-04 20:57:46 UTC) #4
sashab
This is a pretty large patch, and I'm about to go on leave :) eddy ...
4 years, 2 months ago (2016-10-04 23:36:21 UTC) #8
Timothy Loh
stamp lgtm I saw a couple places where you added two spaces after a full ...
4 years, 2 months ago (2016-10-05 04:22:53 UTC) #10
Nico
On 2016/10/05 04:22:53, Timothy Loh wrote: > stamp lgtm > > I saw a couple ...
4 years, 2 months ago (2016-10-05 13:43:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392143002/20001
4 years, 2 months ago (2016-10-05 13:43:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 13:51:22 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:54:19 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/566600aa3bb9d95b58e8824c50abd5a3c1657dd2
Cr-Commit-Position: refs/heads/master@{#423145}

Powered by Google App Engine
This is Rietveld 408576698