Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 239213003: Revert of Prevents double-clicks on a tab close button from aslo maximizing the browser (Closed)

Created:
6 years, 8 months ago by bungeman-skia
Modified:
6 years, 8 months ago
Reviewers:
flackr, varkha, sadrul, jonross
CC:
chromium-reviews, kalyank, ben+views_chromium.org, sadrul, ben+ash_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Prevents double-clicks on a tab close button from aslo maximizing the browser (https://codereview.chromium.org/222203006/) Reason for revert: Broke build. Original issue's description: > Prevents double-clicks on a tab close button from aslo maximizing the browser > > The code responsible for listening to a double-click, and for maximizing the > browser is platform dependant. The path on Aura desktop differs from that of > Chrome OS. In both cases they use alternate means to trigger the maximizing. > > This change modifies both so that they only attempt to maximize if the initial > click has the same target as the second click. Tab deletion is destructive by > nature, lead do different targets processing different parts of the same series > of user events. > > TEST=WorkspaceEventHandlerTest > BUG=348817 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263841 TBR=flackr@chromium.org,varkha@chromium.org,sadrul@chromium.org,jonross@chromium.org NOTREECHECKS=true NOTRY=true BUG=348817 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -372 lines) Patch
M ash/wm/toplevel_window_event_handler.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 3 chunks +31 lines, -61 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 20 chunks +44 lines, -138 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 6 chunks +8 lines, -132 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 3 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bungeman-skia
Created Revert of Prevents double-clicks on a tab close button from aslo maximizing the browser
6 years, 8 months ago (2014-04-15 15:15:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bungeman@google.com/239213003/1
6 years, 8 months ago (2014-04-15 15:16:24 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-15 15:17:41 UTC) #3
Message was sent while issue was closed.
Change committed as 263855

Powered by Google App Engine
This is Rietveld 408576698