Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2813)

Unified Diff: ash/wm/toplevel_window_event_handler.cc

Issue 239213003: Revert of Prevents double-clicks on a tab close button from aslo maximizing the browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/workspace/workspace_event_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/toplevel_window_event_handler.cc
diff --git a/ash/wm/toplevel_window_event_handler.cc b/ash/wm/toplevel_window_event_handler.cc
index f20a13fc7dd2b90e8601a284defbc3a6d5236783..8b6c9ba04542badc4444a7dc5fdb951afd4540a4 100644
--- a/ash/wm/toplevel_window_event_handler.cc
+++ b/ash/wm/toplevel_window_event_handler.cc
@@ -476,10 +476,7 @@
ConvertPointToParent(target, event->location()));
AttemptToStartDrag(target, location_in_parent, component,
aura::client::WINDOW_MOVE_SOURCE_MOUSE);
- // Set as handled so that other event handlers do no act upon the event
- // but still receive it so that they receive both parts of each pressed/
- // released pair.
- event->SetHandled();
+ event->StopPropagation();
} else {
CompleteDrag(DRAG_COMPLETE);
}
@@ -494,13 +491,12 @@
CompleteDrag(event->type() == ui::ET_MOUSE_RELEASED ?
DRAG_COMPLETE : DRAG_REVERT);
// Completing the drag may result in hiding the window. If this happens
- // mark the event as handled so no other handlers/observers act upon the
- // event. They should see the event on a hidden window, to determine targets
- // of destructive actions such as hiding. They should not act upon them.
+ // return true so no other handlers/observers see the event. Otherwise
+ // they see the event on a hidden window.
if (window_resizer_ &&
event->type() == ui::ET_MOUSE_CAPTURE_CHANGED &&
!target->IsVisible()) {
- event->SetHandled();
+ event->StopPropagation();
}
}
« no previous file with comments | « no previous file | ash/wm/workspace/workspace_event_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698