Chromium Code Reviews Chromium Code Reviews
Issue 2392033002:
Correcting text baseline for tiny fonts (Closed)
| Index: third_party/WebKit/LayoutTests/fast/canvas/canvas-text-baseline-tiny-fonts.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/canvas/canvas-text-baseline-tiny-fonts.html b/third_party/WebKit/LayoutTests/fast/canvas/canvas-text-baseline-tiny-fonts.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..5fe24e78987934bbb001504e399d41373ea797a2 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/canvas/canvas-text-baseline-tiny-fonts.html |
| @@ -0,0 +1,38 @@ |
| +<!DOCTYPE html> |
| +<canvas id="canvas1" width=200 height=250></canvas> |
| +<canvas id="canvas2" width=250 height=250></canvas> |
| +<canvas id="canvas3" width=250 height=250></canvas> |
| +<canvas id="canvas4" width=250 height=250></canvas> |
| + |
| +<script> |
| +if (window.testRunner) |
| + window.testRunner.dumpAsTextWithPixelResults(); |
| + |
| +function draw() { |
| + // The code works fine with 1px font size, however testing that makes |
| + // the test flaky due to pixel differences. |
| + for(i = 2; i <= 4; i++) { |
|
qyearsley
2016/10/14 17:46:44
Nit: Normally there's a space after `for` and befo
|
| + var ctx = document.getElementById("canvas" + i).getContext("2d"); |
| + ctx.scale(25, 25); |
| + ctx.lineWidth = 0.1; |
| + |
| + ctx.beginPath(); |
| + ctx.moveTo(0, 5); |
| + ctx.lineTo(20, 5); |
| + ctx.stroke(); |
| + |
| + ctx.font = i + "px sans-serif" |
| + ctx.textBaseline = "top" |
| + ctx.strokeText("A", 1, 5); |
| + ctx.textBaseline = "middle" |
| + ctx.strokeText("B", 3, 5); |
| + ctx.textBaseline = "alphabetic" |
| + ctx.strokeText("C", 5, 5); |
| + ctx.textBaseline = "bottom" |
|
qyearsley
2016/10/14 17:46:44
Nit: could add semicolons at the end of each state
|
| + ctx.strokeText("D", 7, 5); |
| + } |
| +} |
| + |
| +window.onload = draw; |
| +</script> |
| + |
|
qyearsley
2016/10/14 17:46:44
Nit: extra newline
|
