third_party/WebKit/LayoutTests/fast/canvas/canvas-text-baseline-tiny-fonts.html - Issue 2392033002: Correcting text baseline for tiny fonts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-text-baseline-tiny-fonts.html

Issue 2392033002: Correcting text baseline for tiny fonts (Closed)

Patch Set: Fixing flaky layout tests. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <canvas id="canvas1" width=200 height=250></canvas>

	3 <canvas id="canvas2" width=250 height=250></canvas>

	4 <canvas id="canvas3" width=250 height=250></canvas>

	5 <canvas id="canvas4" width=250 height=250></canvas>

	6

	7 <script>

	8 if (window.testRunner)

	9 window.testRunner.dumpAsTextWithPixelResults();

	10

	11 function draw() {

	12 // The code works fine with 1px font size, however testing that makes

	13 // the test flaky due to pixel differences.

	14 for(i = 2; i <= 4; i++) {
	qyearsley 2016/10/14 17:46:44 Nit: Normally there's a space after `for` and befo Nit: Normally there's a space after `for` and before the opening parenthesis.
	15 var ctx = document.getElementById("canvas" + i).getContext("2d");

	16 ctx.scale(25, 25);

	17 ctx.lineWidth = 0.1;

	18

	19 ctx.beginPath();

	20 ctx.moveTo(0, 5);

	21 ctx.lineTo(20, 5);

	22 ctx.stroke();

	23

	24 ctx.font = i + "px sans-serif"

	25 ctx.textBaseline = "top"

	26 ctx.strokeText("A", 1, 5);

	27 ctx.textBaseline = "middle"

	28 ctx.strokeText("B", 3, 5);

	29 ctx.textBaseline = "alphabetic"

	30 ctx.strokeText("C", 5, 5);

	31 ctx.textBaseline = "bottom"
	qyearsley 2016/10/14 17:46:44 Nit: could add semicolons at the end of each state Nit: could add semicolons at the end of each statement above.
	32 ctx.strokeText("D", 7, 5);

	33 }

	34 }

	35

	36 window.onload = draw;

	37 </script>

	38
	qyearsley 2016/10/14 17:46:44 Nit: extra newline Nit: extra newline
OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h » ('j') | no next file with comments »