Tweak how the pkg files timestamps are created.

Tweak how the pkg files timestamps are created.

The acute problem this solves is that hacking on DDC generates a large
number of files into its gen/ directory. It's enough files that once you
have done that, the SDK no longer builds successfully because it chokes
on them all.

To fix that, instead of using list_files.py, I made a little
list_dart_files.py that is explicitly for Dart files and knows to
exclude gen/ and tests. This also avoids needing the sort of hairy
regexes to match different sets of files.

As far as I can tell, this works, but GYP is pretty mysterious to me,
so let me know if I got something wrong or there is a better way to do
it.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/8b6ceefca8457affe3cca51a9a39cfddb8ab1ac8

[Bob Nystrom, 2016-10-03 23:36:24]

rnystrom@google.com changed reviewers:
+ ahe@google.com, whesse@google.com

[Bill Hesse, 2016-10-04 08:48:39]

Description was changed from

==========
Tweak how the pkg files timestamps are created.

The acute problem this solves is that hacking on DDC generates a large
number of files into its gen/ directory. It's enough files that once you
have done that, the SDK no longer builds successfully because it chokes
on them all.

To fix that, instead of using list_files.py, I made a little
list_dart_files.py that is explicitly for Dart files and knows to
exclude gen/ and tests. This also avoids needing the sort of hairy
regexes to match different sets of files.

As far as I can tell, this works, but GYP is pretty mysterious to me,
so let me know if I got something wrong or there is a better way to do
it.
==========

to

==========
Tweak how the pkg files timestamps are created.

The acute problem this solves is that hacking on DDC generates a large
number of files into its gen/ directory. It's enough files that once you
have done that, the SDK no longer builds successfully because it chokes
on them all.

To fix that, instead of using list_files.py, I made a little
list_dart_files.py that is explicitly for Dart files and knows to
exclude gen/ and tests. This also avoids needing the sort of hairy
regexes to match different sets of files.

As far as I can tell, this works, but GYP is pretty mysterious to me,
so let me know if I got something wrong or there is a better way to do
it.
==========

[Bill Hesse, 2016-10-04 08:57:18]

lgtm

https://codereview.chromium.org/2391863002/diff/1/tools/list_dart_files.py
File tools/list_dart_files.py (right):

https://codereview.chromium.org/2391863002/diff/1/tools/list_dart_files.py#ne...
tools/list_dart_files.py:4: # BSD-style license that can be found in the LICENSE
file.
Since this tool is all about not hitting the xcode limit on file list length,
could we make the tool check if the length of its output is close to or over
that length, and report an error?

This can be done in a separate CL, or an issue can be filed to do this.

[Bob Nystrom, 2016-10-04 14:57:43]

On 2016/10/04 08:57:18, Bill Hesse wrote:
> lgtm
> 
> https://codereview.chromium.org/2391863002/diff/1/tools/list_dart_files.py
> File tools/list_dart_files.py (right):
> 
>
https://codereview.chromium.org/2391863002/diff/1/tools/list_dart_files.py#ne...
> tools/list_dart_files.py:4: # BSD-style license that can be found in the
LICENSE
> file.
> Since this tool is all about not hitting the xcode limit on file list length,
> could we make the tool check if the length of its output is close to or over
> that length, and report an error?

Sure thing. What is that limit?

– bob

[Bob Nystrom, 2016-10-04 23:56:15]

Description was changed from

==========
Tweak how the pkg files timestamps are created.

The acute problem this solves is that hacking on DDC generates a large
number of files into its gen/ directory. It's enough files that once you
have done that, the SDK no longer builds successfully because it chokes
on them all.

To fix that, instead of using list_files.py, I made a little
list_dart_files.py that is explicitly for Dart files and knows to
exclude gen/ and tests. This also avoids needing the sort of hairy
regexes to match different sets of files.

As far as I can tell, this works, but GYP is pretty mysterious to me,
so let me know if I got something wrong or there is a better way to do
it.
==========

to

==========
Tweak how the pkg files timestamps are created.

The acute problem this solves is that hacking on DDC generates a large
number of files into its gen/ directory. It's enough files that once you
have done that, the SDK no longer builds successfully because it chokes
on them all.

To fix that, instead of using list_files.py, I made a little
list_dart_files.py that is explicitly for Dart files and knows to
exclude gen/ and tests. This also avoids needing the sort of hairy
regexes to match different sets of files.

As far as I can tell, this works, but GYP is pretty mysterious to me,
so let me know if I got something wrong or there is a better way to do
it.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8b6ceefca8457affe3cca51a9a39cfddb8ab1ac8
==========

[Bob Nystrom, 2016-10-04 23:56:16]

Committed patchset #1 (id:1) manually as
8b6ceefca8457affe3cca51a9a39cfddb8ab1ac8 (presubmit successful).