Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: pkg/pkg_files.gyp

Issue 2391863002: Tweak how the pkg files timestamps are created. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/list_dart_files.py » ('j') | tools/list_dart_files.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/pkg_files.gyp
diff --git a/pkg/pkg_files.gyp b/pkg/pkg_files.gyp
index 9dd13e3c9a2eb779e5ddb2e13df1882866eb4986..55dd28467b86ffa2c20fde2c4156250003c35af8 100644
--- a/pkg/pkg_files.gyp
+++ b/pkg/pkg_files.gyp
@@ -9,8 +9,8 @@
# This target lists all the files in pkg and third_party/pkg,
# and creates the timestamp pkg_files.stamp, which depends on some
# intermediate helper timestamps.
- # We split third_party/pkg up into three groups, based on the last
- # character before .dart at the end of the filename.
+ # We split third_party/pkg up into three groups, based on the first letter
+ # of the package name.
{
'target_name': 'pkg_files_stamp',
'type': 'none',
@@ -19,12 +19,10 @@
'action_name': 'make_pkg_files_stamp',
'inputs': [
'../tools/create_timestamp_file.py',
- '<!@(["python", "../tools/list_files.py",'
- '"^(?!.*/test/).*(?<!_test)[.]dart$",'
- '"."])',
- '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_1.stamp',
- '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_2.stamp',
- '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_3.stamp',
+ '<!@(["python", "../tools/list_dart_files.py", "."])',
+ '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_a_k.stamp',
+ '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_l_r.stamp',
+ '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_s_z.stamp',
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/pkg_files.stamp',
@@ -35,15 +33,13 @@
],
},
{
- 'action_name': 'make_third_party_pkg_files_1_stamp',
+ 'action_name': 'make_third_party_pkg_files_a_k_stamp',
'inputs': [
'../tools/create_timestamp_file.py',
- '<!@(["python", "../tools/list_files.py",'
- '"^(?!.*_test\.dart).*[a-k]\.dart$",'
- '"../third_party/pkg"])',
+ '<!@(["python", "../tools/list_dart_files.py", "../third_party/pkg", "[a-k].*"])',
],
'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_1.stamp',
+ '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_a_k.stamp',
],
'action': [
'python', '../tools/create_timestamp_file.py',
@@ -51,15 +47,13 @@
],
},
{
- 'action_name': 'make_third_party_pkg_files_2_stamp',
+ 'action_name': 'make_third_party_pkg_files_l_r_stamp',
'inputs': [
'../tools/create_timestamp_file.py',
- '<!@(["python", "../tools/list_files.py",'
- '"^(?!.*_test\.dart).*[l-r]\.dart$",'
- '"../third_party/pkg"])',
+ '<!@(["python", "../tools/list_dart_files.py", "../third_party/pkg", "[l-r].*"])',
],
'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_2.stamp',
+ '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_l_r.stamp',
],
'action': [
'python', '../tools/create_timestamp_file.py',
@@ -67,15 +61,13 @@
],
},
{
- 'action_name': 'make_third_party_pkg_files_3_stamp',
+ 'action_name': 'make_third_party_pkg_files_s_z_stamp',
'inputs': [
'../tools/create_timestamp_file.py',
- '<!@(["python", "../tools/list_files.py",'
- '"^(?!.*_test\.dart).*[^a-r]\.dart$",'
- '"../third_party/pkg"])',
+ '<!@(["python", "../tools/list_dart_files.py", "../third_party/pkg", "[s-z].*"])',
],
'outputs': [
- '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_3.stamp',
+ '<(SHARED_INTERMEDIATE_DIR)/third_party_pkg_files_s_z.stamp',
],
'action': [
'python', '../tools/create_timestamp_file.py',
« no previous file with comments | « no previous file | tools/list_dart_files.py » ('j') | tools/list_dart_files.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698