Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2391823003: [HBD] Hardcode SEI threshold to 30 (for testers) (Closed)

Created:
4 years, 2 months ago by tommycli
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HBD] Hardcode SEI threshold to 30 (for testers) Normal users will have it configured to the real value via Finch. This hardcoding is only for ease of testing in case the user does not have a Finch config. BUG=650903 Committed: https://crrev.com/ef97eaf65cfaaa1728bfeebb0fa82701a4d5481c Cr-Commit-Position: refs/heads/master@{#422966}

Patch Set 1 #

Patch Set 2 : fix broken test configs #

Patch Set 3 : fix one more test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -40 lines) Patch
M chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugins_field_trial.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 2 chunks +15 lines, -20 lines 1 comment Download

Messages

Total messages: 32 (19 generated)
tommycli
dominickn: PTAL, thanks!
4 years, 2 months ago (2016-10-04 00:51:36 UTC) #4
dominickn
lgtm
4 years, 2 months ago (2016-10-04 00:54:27 UTC) #5
tommycli
On 2016/10/04 00:54:27, dominickn wrote: > lgtm thank you!
4 years, 2 months ago (2016-10-04 00:55:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391823003/1
4 years, 2 months ago (2016-10-04 00:55:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/272663)
4 years, 2 months ago (2016-10-04 01:03:24 UTC) #11
tommycli
thestig: PTAL chrome/ stamp plz thanks!
4 years, 2 months ago (2016-10-04 22:03:13 UTC) #19
Lei Zhang
rs lgtm
4 years, 2 months ago (2016-10-04 22:13:36 UTC) #22
tommycli
On 2016/10/04 22:13:36, Lei Zhang wrote: > rs lgtm thank you sir!
4 years, 2 months ago (2016-10-04 22:14:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391823003/40001
4 years, 2 months ago (2016-10-04 22:15:51 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 22:23:48 UTC) #27
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ef97eaf65cfaaa1728bfeebb0fa82701a4d5481c Cr-Commit-Position: refs/heads/master@{#422966}
4 years, 2 months ago (2016-10-04 22:25:39 UTC) #29
Reid Kleckner
https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerender/prerender_browsertest.cc File chrome/browser/prerender/prerender_browsertest.cc (right): https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerender/prerender_browsertest.cc#newcode1369 chrome/browser/prerender/prerender_browsertest.cc:1369: CONTENT_SETTING_ALLOW); This change broke this test on all the ...
4 years, 2 months ago (2016-10-05 17:32:47 UTC) #31
tommycli
4 years, 2 months ago (2016-10-05 17:34:34 UTC) #32
Message was sent while issue was closed.
On 2016/10/05 17:32:47, Reid Kleckner wrote:
>
https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerende...
> File chrome/browser/prerender/prerender_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerende...
> chrome/browser/prerender/prerender_browsertest.cc:1369:
CONTENT_SETTING_ALLOW);
> This change broke this test on all the Clang ToT Win64 bots:
>
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%20tester/bui...

No problem I'll take a look.

Powered by Google App Engine
This is Rietveld 408576698