|
|
Description[HBD] Hardcode SEI threshold to 30 (for testers)
Normal users will have it configured to the real value via Finch. This
hardcoding is only for ease of testing in case the user does not have
a Finch config.
BUG=650903
Committed: https://crrev.com/ef97eaf65cfaaa1728bfeebb0fa82701a4d5481c
Cr-Commit-Position: refs/heads/master@{#422966}
Patch Set 1 #Patch Set 2 : fix broken test configs #Patch Set 3 : fix one more test #
Total comments: 1
Messages
Total messages: 32 (19 generated)
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tommycli@chromium.org changed reviewers: + dominickn@chromium.org
dominickn: PTAL, thanks!
lgtm
The CQ bit was unchecked by tommycli@chromium.org
The CQ bit was checked by tommycli@chromium.org
On 2016/10/04 00:54:27, dominickn wrote: > lgtm thank you!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tommycli@chromium.org changed reviewers: + thestig@chromium.org
thestig: PTAL chrome/ stamp plz thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rs lgtm
On 2016/10/04 22:13:36, Lei Zhang wrote: > rs lgtm thank you sir!
The CQ bit was checked by tommycli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dominickn@chromium.org Link to the patchset: https://codereview.chromium.org/2391823003/#ps40001 (title: "fix one more test")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [HBD] Hardcode SEI threshold to 30 (for testers) Normal users will have it configured to the real value via Finch. This hardcoding is only for ease of testing in case the user does not have a Finch config. BUG=650903 ========== to ========== [HBD] Hardcode SEI threshold to 30 (for testers) Normal users will have it configured to the real value via Finch. This hardcoding is only for ease of testing in case the user does not have a Finch config. BUG=650903 Committed: https://crrev.com/ef97eaf65cfaaa1728bfeebb0fa82701a4d5481c Cr-Commit-Position: refs/heads/master@{#422966} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ef97eaf65cfaaa1728bfeebb0fa82701a4d5481c Cr-Commit-Position: refs/heads/master@{#422966}
Message was sent while issue was closed.
rnk@chromium.org changed reviewers: + rnk@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerende... File chrome/browser/prerender/prerender_browsertest.cc (right): https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerende... chrome/browser/prerender/prerender_browsertest.cc:1369: CONTENT_SETTING_ALLOW); This change broke this test on all the Clang ToT Win64 bots: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%20tester/bui...
Message was sent while issue was closed.
On 2016/10/05 17:32:47, Reid Kleckner wrote: > https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerende... > File chrome/browser/prerender/prerender_browsertest.cc (right): > > https://codereview.chromium.org/2391823003/diff/40001/chrome/browser/prerende... > chrome/browser/prerender/prerender_browsertest.cc:1369: CONTENT_SETTING_ALLOW); > This change broke this test on all the Clang ToT Win64 bots: > https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%20tester/bui... No problem I'll take a look. |